Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Package Pretzel as a global tool #360

Merged
merged 19 commits into from
Oct 29, 2019
Merged

Package Pretzel as a global tool #360

merged 19 commits into from
Oct 29, 2019

Conversation

biohazard999
Copy link
Contributor

@biohazard999 biohazard999 commented Oct 24, 2019 •
edited
Loading

Packs Pretzel as a global tool.

relates to #338

@laedit should be ready for review :)

@biohazard999
Merge pull request #1 from Code52/master
cdd46f7 
Dotliquid sorting (Code52#325)
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
af746d5
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
6a99682
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
4e9edfd
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
083ac1f
@biohazard999
Merge branch 'master' of https://github.com/biohazard999/pretzel
0eb174e
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
f4171c0
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
576ada4
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
797c337
@biohazard999
Merge branch 'master' of https://github.com/Code52/pretzel
3a9e22c
@biohazard999
Merge branch 'master' of https://github.com/biohazard999/pretzel
3aa44f4
@biohazard999
Merge branch 'master' of https://github.com/biohazard999/pretzel
fcecda2
@biohazard999
feat: pack as global tool
1182258
@biohazard999 biohazard999 marked this pull request as ready for review October 24, 2019 15:21
@laedit laedit self-requested a review October 25, 2019 06:07
@laedit
Copy link
Member

laedit commented Oct 25, 2019

Seems good to me, can you just update appveyor.yml to add Pretzel.Tool in the artifacts and in the nuget deploy?
Since I think dotnet global tools need to be available from nuget, right?

@biohazard999
Copy link
Contributor Author

Seems good to me, can you just update appveyor.yml to add Pretzel.Tool in the artifacts and in the nuget deploy?
Since I think dotnet global tools need to be available from nuget, right?

So you mean like so? I wasn't aware that you can specify them in appveyor.yml as well

laedit
laedit suggested changes Oct 25, 2019
View reviewed changes
laedit
laedit reviewed Oct 28, 2019
View reviewed changes
@laedit laedit merged commit 0cf4f67 into Code52:master Oct 29, 2019
@biohazard999 biohazard999 deleted the topic/pack-as-global-tool-338 branch October 29, 2019 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laedit laedit laedit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biohazard999 @laedit