Skip to content

Conversation

@nndat
Copy link

@nndat nndat commented Oct 22, 2025

User description

  • Fix function name from tree_sitter_tree_sitter_vb_dotnet to tree_sitter_vb_dotnet
  • Resolves ImportError: symbol not found in flat namespace
  • Function name in binding.c now matches the actual function in parser.c

CodeAnt-AI Description

Fix Python import error for VB.NET parser by correcting binding function name

What Changed

  • The Python binding now exposes the correct VB.NET function name so importing the VB.NET extension no longer fails with a missing-symbol ImportError.
  • Importing the VB.NET module now returns the correct language object, allowing Python code to load and use the VB.NET parser.
  • Python-based tools that rely on the VB.NET language capsule (for parsing, syntax highlighting, or code analysis) will work again after this change.

Impact

✅ Fixes ImportError when importing VB.NET Python binding
✅ Restores VB.NET parsing in Python tools (syntax highlighting, analysis)
✅ Enables successful use of the VB.NET extension in Python environments

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

- Fix function name from tree_sitter_tree_sitter_vb_dotnet to tree_sitter_vb_dotnet
- Resolves ImportError: symbol not found in flat namespace
- Function name in binding.c now matches the actual function in parser.c
@codeant-ai
Copy link

codeant-ai bot commented Oct 22, 2025

CodeAnt AI is reviewing your PR.

@codeant-ai codeant-ai bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Oct 22, 2025

static PyObject* _binding_language(PyObject *Py_UNUSED(self), PyObject *Py_UNUSED(args)) {
return PyCapsule_New(tree_sitter_tree_sitter_vb_dotnet(), "tree_sitter.Language", NULL);
return PyCapsule_New(tree_sitter_vb_dotnet(), "tree_sitter.Language", NULL);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Check the pointer returned by tree_sitter_vb_dotnet() for NULL before creating the PyCapsule and raise a Python exception (return NULL) if initialization failed. [possible bug]

Severity Level: Critical 🚨

Suggested change
return PyCapsule_New(tree_sitter_vb_dotnet(), "tree_sitter.Language", NULL);
TSLanguage *lang = tree_sitter_vb_dotnet();
if (!lang) {
PyErr_SetString(PyExc_RuntimeError, "Failed to initialize tree-sitter language");
return NULL;
}
return PyCapsule_New((void *)lang, "tree_sitter.Language", NULL);
Why it matters? ⭐

Creating a PyCapsule wrapping a NULL TSLanguage pointer can hide an initialization failure and lead to confusing downstream errors. Checking for NULL and raising a Python exception surfaces the failure immediately and is a sensible defensive change for robustness.

Prompt for AI Agent 🤖
<code>This is a comment left during a code review.

**Path:** bindings/python/tree_sitter_tree_sitter_vb_dotnet/binding.c
**Line:** 8:8
**Comment:**
	*Possible Bug: Check the pointer returned by `tree_sitter_vb_dotnet()` for NULL before creating the PyCapsule and raise a Python exception (return NULL) if initialization failed.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, please make it concise.

@codeant-ai
Copy link

codeant-ai bot commented Oct 22, 2025

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant