Skip to content

allow user resizing of sidebar #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow user resizing of sidebar #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...javascript/components/workflows/student/exams/show/components/navbar/NavAccordionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const NavAccordionItem: React.FC<NavAccordionItemProps> = (props) => {
onClick={(): void => onSectionClick(eventKey)}
>
<RenderIcon I={Icon} className="" />
<span aria-hidden="true" className="width-0">&nbsp;</span>
<span aria-hidden="true" className="mw-0">&nbsp;</span>
<Collapse
in={expanded}
dimension="width"
Expand Down
14 changes: 12 additions & 2 deletions app/javascript/components/workflows/student/exams/show/components/navbar/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
.sidebar-small {
width: var(--sidebar-small);
transition: 0.35s max-width ease-in-out, 0.35s min-width ease-in-out;
min-width: var(--sidebar-small);
max-width: var(--sidebar-small);
}

.sidebar-expanded {
width: var(--sidebar-expanded);
transition: 0.35s max-width ease-in-out, 0.35s min-width ease-in-out;
min-width: var(--sidebar-expanded);
max-width: 50%;
resize: horizontal;
overflow: auto;
}

.mw-0 {
max-width: 0;
}

.collapse:not(.width):not(.show) {
Expand Down
4 changes: 1 addition & 3 deletions app/javascript/components/workflows/student/exams/show/components/navbar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ const ExamNavbar: React.FC<{
const additionalClass = expanded ? 'sidebar-expanded' : 'sidebar-small';
return (
<div
id="sidebar"
className={`
transition
bg-dark
text-white
float-left
Expand All @@ -140,7 +138,7 @@ const ExamNavbar: React.FC<{
Hourglass
</h1>
</Collapse>
<h1 aria-hidden="true" className="width-0">&nbsp;</h1>
<h1 aria-hidden="true" className="mw-0">&nbsp;</h1>
<Button
className="ml-2"
onClick={(): void => {
Expand Down