-
Notifications
You must be signed in to change notification settings - Fork 163
almost automatic release to Maven Central #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
01b1f92 to
c726dce
Compare
c726dce to
d9e3b05
Compare
d9e3b05 to
dc8f4c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR automates the release process to Maven Central by replacing manual deployment with an automated API-based upload using a bearer token.
Key Changes:
- Removed manual Maven credentials (username/password) in favor of automated token-based authentication
- Added automatic deployment to Maven Central via Sonatype API with bearer token
- Streamlined release process by removing the draft release step and manual upload requirement
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| deploy/deploy.sh | Removed MAVEN_USER and MAVEN_PASSWORD environment variable checks and parameters from bazel commands, as deployment now uses bearer token authentication |
| CONTRIBUTING.md | Updated release documentation to reflect automated workflow and provided fallback manual deployment instructions |
| .github/workflows/prerelease.yaml | Renamed job to maven_deploy, added automated deployment step using Sonatype API with bearer token, changed bundle artifact to tar.gz format, and removed draft flag from release creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cc1ca50 to
2d78a82
Compare
2d78a82 to
1d95666
Compare
simonresch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
1d95666 to
2b271e2
Compare
Just push the tag to release.