NW6 | Orlando_Morales | HTML-CSS | Module_Project | Week1 #636
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
css/style.css
Outdated
| @@ -15,5 +49,167 @@ body { | |||
| * | |||
| * - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex' | |||
| */ | |||
| .header, .footer { | |||
| padding: 0rem 1rem 0rem 1rem; | |||
| max-width: 1200px; | |||
There was a problem hiding this comment.
setting a max width as 1200px limit your design to fit screen size less or equal to 1200px. This is how it renders on larger screen, which isnt what you are trying to achieve. Please look into this, remove the max-width anywhere you have it and work on the structuring again
| </div> | ||
| </section> | ||
|
|
||
| <section class="Logos"> |
There was a problem hiding this comment.
This section needs to be adjusted in such a way that The Image and the text box exist together in a single div like below.
<div>
<img src="/img/icon-devices.svg" alt="device" class="icon">
<h4 class="iconText">Internet for all devices</h4>
</div>
There was a problem hiding this comment.
I did the changes, put the images and the texts in the same div
| <link rel="stylesheet" href="store.css"> | ||
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico"> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
Your store page design is decent. The positioning issue lingers here as well
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?