Skip to content

ZA-CapeTown | TP-May-2025 | Dawud Vermeulen | Module-Structuring and Testing Data Sprint-2 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Dave-Vermeulen
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • All mandatory subfolders and exercises complete as per instructions in respective README.md

Questions

Please will you review my PR and let me know if any updates are needed. I would appreciate clear instruction. Thank you 🙏🏽

@Dave-Vermeulen Dave-Vermeulen changed the title ZA-CapeTown | TP-May-2025 | Dawud Vermeulen | Module-Structuring and Testing Data ZA-CapeTown | TP-May-2025 | Dawud Vermeulen | Module-Structuring and Testing Data Sprint-2 Jul 21, 2025
@Dave-Vermeulen Dave-Vermeulen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 21, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 22, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - there's just one missing bit you forgot in the first file.

function capitalise(str) {
let str = `${str[0].toUpperCase()}${str.slice(1)}`;
return str;
}

// =============> write your explanation here
// the function takes string arg it gets the first character of the string and capitalises it. the .slice method gets the rest of the string and concats it the capitalized first char. all this is assinged to var called str and returns the str.
// the error says the var str has already been used in the function, this is because the var str is declared in the function and then again in the return statement.
// =============> write your new code here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've identified the problem - can you write some fixed code?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 22, 2025
@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 23, 2025
@LonMcGregor
Copy link

Great work - you can close this sprint now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITP-May-2025 | Structuring and testing data | Dawud Vermeulen
2 participants