Skip to content
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,19 @@ function getAngleType(angle) {
if (angle === 90) {
return "Right angle";
}
// Run the tests, work out what Case 2 is testing, and implement the required code here.
// Then keep going for the other cases, one at a time.
if (angle < 90 && angle > 0) {
return "Acute angle";
}
if (angle > 90 && angle < 180) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking angle > 90 is optional because previous if-statements can guarantee angle is always more than 90.

return "Obtuse angle";
}
if (angle === 180) {
return "Straight angle";
}
if (angle > 180 && angle < 360) {
return "Reflex angle";
}
return "Invalid angle";
}

// The line below allows us to load the getAngleType function into tests in other files.
Expand Down Expand Up @@ -50,14 +61,33 @@ assertEquals(acute, "Acute angle");
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
const obtuse = getAngleType(120);
// ====> write your test here, and then add a line to pass the test in the function above
assertEquals(obtuse, "Obtuse angle");

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
// ====> write your test here, and then add a line to pass the test in the function above

const straight = getAngleType(180);
assertEquals(straight, "Straight angle");
// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
// ====> write your test here, and then add a line to pass the test in the function above
// ====> write your test here, and then add a line to pass the test in the function above
const reflex = getAngleType(270);
assertEquals(reflex, "Reflex angle");

let angle = 120;
console.log(angle + " degrees is a " + getAngleType(angle));
angle = 45;
console.log(angle + " degrees is a " + getAngleType(angle));
angle = 90;
console.log(angle + " degrees is a " + getAngleType(angle));
angle = 180;
console.log(angle + " degrees is a " + getAngleType(angle));
angle = 270;
console.log(angle + " degrees is a " + getAngleType(angle));
angle = -10;
console.log(angle + " degrees is a " + getAngleType(angle));
angle = 400;
console.log(angle + " degrees is a " + getAngleType(angle));
// Case 6: Handle Invalid Angles:
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ function isProperFraction(numerator, denominator) {
if (numerator < denominator) {
return true;
}
if (numerator < 0 && Math.abs(numerator) < denominator) {
return false;
}
if (numerator >= denominator) {
return false;
}
// we could add more checks here for invalid input, but not required for this exercise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the definition of proper fraction in mathematics:

  • isProperFraction(-4, 3) should return false
  • isProperFraction(-2, 5) should return true
  • isProperFraction(-1, 1) should return false
  • isProperFraction(-2, -3) should return true

Can you look up the definition of proper fraction and update your function accordingly?

}

// The line below allows us to load the isProperFraction function into tests in other files.
Expand Down Expand Up @@ -47,13 +54,55 @@ assertEquals(improperFraction, false);
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
const negativeFraction = isProperFraction(-4, 7);
// ====> complete with your assertion
assertEquals(negativeFraction, true);

// Equal Numerator and Denominator check:
// Input: numerator = 3, denominator = 3
// target output: false
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
const equalFraction = isProperFraction(3, 3);
// ====> complete with your assertion
assertEquals(equalFraction, false);

// Stretch:
// What other scenarios could you test for?


// Zero Numerator check:
// Input: numerator = 0, denominator = 5
// target output: true
// Explanation: The fraction 0/5 is a proper fraction because the numerator (0) is less than the denominator (5). The function should return true.
const zeroNumerator = isProperFraction(0, 5);
assertEquals(zeroNumerator, true);

// Negative Denominator check:
// Input: numerator = 2, denominator = -3
// target output: false
// Explanation: The fraction 2/-3 is not a proper fraction because the denominator is negative. The function should return false.
const negativeDenominator = isProperFraction(2, -3);
assertEquals(negativeDenominator, true);

let numerator= 1;
let denominator= 7;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= 5;
denominator= 1;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= -4;
denominator= 9;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= 0;
denominator= 6;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= 4;
denominator= 4;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= -5;
denominator= 8;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= 4;
denominator= -2;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
numerator= -3;
denominator= -7;
console.log(numerator + "/" + denominator + " check =", isProperFraction(numerator, denominator));
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,17 @@
// write one test at a time, and make it pass, build your solution up methodically
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
function getCardValue(card) {
const rank = card.slice(0, -1);
if (rank === "A") {
return 11;
}
if (["10", "J", "Q", "K"].includes(rank)) {
return 10;
}
if (["2", "3", "4", "5", "6", "7", "8", "9"].includes(rank)) {
return parseInt(rank, 10);
}
return "Invalid card rank";
}

// The line below allows us to load the getCardValue function into tests in other files.
Expand Down Expand Up @@ -38,20 +46,51 @@ assertEquals(aceofSpades, 11);
// Given a card with a rank between "2" and "9",
// When the function is called with such a card,
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
const fiveofHearts = getCardValue("5♥");
const fiveofHearts = getCardValue("5♥");
// ====> write your test here, and then add a line to pass the test in the function above
assertEquals(fiveofHearts, 5);

// Handle Face Cards (J, Q, K):
// Given a card with a rank of "10," "J," "Q," or "K",
// When the function is called with such a card,
// Then it should return the value 10, as these cards are worth 10 points each in blackjack.
const kingofDiamonds = getCardValue("K♦");
assertEquals(kingofDiamonds, 10);

const jackofHearts = getCardValue("J♥");
assertEquals(jackofHearts, 10);

const queenofSpades = getCardValue("Q♠");
assertEquals(queenofSpades, 10);

const tenofClubs = getCardValue("10♣");
assertEquals(tenofClubs, 10);

// Handle Ace (A):
// Given a card with a rank of "A",
// When the function is called with an Ace,
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
const aceofClubs = getCardValue("A♣");
assertEquals(aceofClubs, 11);

// Handle Invalid Cards:
// Given a card with an invalid rank (neither a number nor a recognized face card),
// When the function is called with such a card,
// Then it should throw an error indicating "Invalid card rank."
const invalidCard = getCardValue("1♠");
assertEquals(invalidCard, "Invalid card rank");
const invalidCard2 = getCardValue("11♠");
assertEquals(invalidCard2, "Invalid card rank");
const invalidCard3 = getCardValue("B♠");
assertEquals(invalidCard3, "Invalid card rank");


console.log( getCardValue("1♠"));
console.log( getCardValue("11♠"));
console.log( getCardValue("B♠"));
console.log( getCardValue("3♠"));
console.log( getCardValue("10♠"));
console.log( getCardValue("J♠"));
console.log( getCardValue("Q♠"));
console.log( getCardValue("K♠"));
console.log( getCardValue("A♠"));
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,24 @@ test("should identify right angle (90°)", () => {
// Case 2: Identify Acute Angles:
// When the angle is less than 90 degrees,
// Then the function should return "Acute angle"

test("should identify acute angle (<90°)", () => {
expect(getAngleType(45)).toEqual("Acute angle");
});
// Case 3: Identify Obtuse Angles:
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"

test("should identify obtuse angle (90°<angle<180°)", () => {
expect(getAngleType(120)).toEqual("Obtuse angle");
});
// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"

test("should identify straight angle (180°)", () => {
expect(getAngleType(180)).toEqual("Straight angle");
});
// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
test("should identify reflex angle (180°<angle<360°)", () => {
expect(getAngleType(270)).toEqual("Reflex angle");
});
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,16 @@ test("should return true for a proper fraction", () => {
});

// Case 2: Identify Improper Fractions:
test("should return false for an improper fraction", () => {
expect(isProperFraction(5, 2)).toEqual(false);
});

// Case 3: Identify Negative Fractions:
test("should return false for a negative fraction", () => {
expect(isProperFraction(-1, 2)).toEqual(true);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description does not quite match the specified test.


// Case 4: Identify Equal Numerator and Denominator:
test("should return false for equal numerator and denominator", () => {
expect(isProperFraction(3, 3)).toEqual(false);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each test, we could include multiple test cases that belong to the same category to make the test more complete in the following way:

test("should return false for equal numerator and denominator", () => {
  expect(isProperFraction(3, 3)).toEqual(false);
  expect(isProperFraction(-3, 3)).toEqual(false);
  expect(isProperFraction(3, -3)).toEqual(false);
  expect(isProperFraction(-3, -3)).toEqual(false);
});