-
-
Notifications
You must be signed in to change notification settings - Fork 240
Glasgow | 25-ITP-Sep | Fares Bakhet | Sprint 3 | coursework/sprint-3-practice-tdd #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 9 commits
6ab27fc
9c2b470
48dba8f
76de1ca
7323aba
80cde9a
bea3492
44f3ca1
c2a674b
7d3028f
1590eec
2478386
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| function countChar(str, char) { | ||
| return str.split(char).length - 1; | ||
| } | ||
|
|
||
| module.exports = countChar; | ||
|
|
||
| console.log( | ||
| countChar( | ||
| "The split() method of String values takes a pattern and divides this string into an ordered list of substrings by searching for the pattern, puts these substrings into an array, and returns the array.", | ||
| "a" | ||
| ) | ||
| ); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,40 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| num = num.toString(); | ||
| if ( | ||
| num.slice(-2) === "11" || | ||
| num.slice(-2) === "12" || | ||
| num.slice(-2) === "13" | ||
| ) { | ||
| return num + "th"; | ||
| } else if (num.slice(-1) === "1") { | ||
| return num + "st"; | ||
| } else if (num.slice(-1) === "2") { | ||
| return num + "nd"; | ||
| } else if (num.slice(-1) === "3") { | ||
| return num + "rd"; | ||
| } | ||
| return num + "th"; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
|
|
||
| console.log(getOrdinalNumber(1)); | ||
| console.log(getOrdinalNumber(2)); | ||
| console.log(getOrdinalNumber(3)); | ||
| console.log(getOrdinalNumber(4)); | ||
| console.log(getOrdinalNumber(5)); | ||
| console.log(getOrdinalNumber(6)); | ||
| console.log(getOrdinalNumber(7)); | ||
| console.log(getOrdinalNumber(8)); | ||
| console.log(getOrdinalNumber(9)); | ||
| console.log(getOrdinalNumber(10)); | ||
| console.log(getOrdinalNumber(11)); | ||
| console.log(getOrdinalNumber(12)); | ||
| console.log(getOrdinalNumber(13)); | ||
| console.log(getOrdinalNumber(21)); | ||
| console.log(getOrdinalNumber(22)); | ||
| console.log(getOrdinalNumber(23)); | ||
| console.log(getOrdinalNumber(101)); | ||
| console.log(getOrdinalNumber(111)); | ||
| console.log(getOrdinalNumber(112)); | ||
| console.log(getOrdinalNumber(113)); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,27 @@ const getOrdinalNumber = require("./get-ordinal-number"); | |
| // continue testing and implementing getOrdinalNumber for additional cases | ||
| // Write your tests using Jest - remember to run your tests often for continual feedback | ||
|
|
||
| // Case 1: Identify the ordinal number for 1 | ||
| // When the number is 1, | ||
| // Then the function should return "1st" | ||
|
|
||
| test("should return '1st' for 1", () => { | ||
| test("append 'st' to numbers ending in 1,except those ending in 11", () => { | ||
| expect(getOrdinalNumber(1)).toEqual("1st"); | ||
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(101)).toEqual("101st"); | ||
| }); | ||
|
|
||
| test("append 'nd' to numbers ending in 2, except those ending in 12", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(132)).toEqual("132nd"); | ||
| }); | ||
|
|
||
| test("append 'rd' to numbers ending in 3, except those ending in 13", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(23)).toEqual("23rd"); | ||
| expect(getOrdinalNumber(133)).toEqual("133rd"); | ||
| }); | ||
|
|
||
| test("should return 'th' for the rest numbers", () => { | ||
|
||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(34)).toEqual("34th"); | ||
| expect(getOrdinalNumber(134)).toEqual("134th"); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,16 @@ | ||
| function repeat() { | ||
| return "hellohellohello"; | ||
| function repeat(str, count) { | ||
| //const str = arguments[0]; | ||
| //const count = arguments[1]; | ||
|
||
| if (count < 0) { | ||
| throw new Error("Count must be a non-negative integer"); | ||
| } | ||
| let result = ""; | ||
| for (let i = 0; i < count; i++) { | ||
| result += str; | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| module.exports = repeat; | ||
|
|
||
| console.log(repeat("hello", 3)); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.
For example, we can prepare a test for numbers 2, 22, 132, etc. as
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjyuan, Done 🫡