Skip to content

Conversation

@Della-Bella
Copy link

Self checklist

  • [X ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Hi volunteer,

Here are my Sprint 2 exercise practices.

Thank you for your time to look at my work,

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Della-Bella Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Coursework) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Della-Bella Della-Bella changed the title London | Sep-2025 | Gislaine Della Bella | Coursework | Sprint-2 London | Sep-2025 | Gislaine Della Bella | Sprint | coursework-sprint-2 Oct 13, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Della-Bella Della-Bella changed the title London | Sep-2025 | Gislaine Della Bella | Sprint | coursework-sprint-2 London | Sep-2025 | Gislaine Della Bella | Sprint 2 | coursework-sprint-2 Oct 13, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

// =============> to use the function that gives a result need to use RETURN not consol.log inside the function

function multiply(a, b) {
const forAllMutiply = (a * b);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve this using a single line rather than 2 lines?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

function multiply(num1, num2) {
return num1 * num2;
}

console.log(The result of multiplying 10 and 32 is ${multiply(10, 32)});


function takeSapcestoUpercase (textSnake){

let takespace = textExemple.split(" ");// returns array nned to tranform to string again before upercase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't look quite right, can you take another look?

  • What happens if you call it like this: console.log(takeSapcestoUpercase("cat dog rabbit")
  • There are a few spelling errors here that make it difficult to read, can you fix those?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @LonMcGregor,
fixed,

thank you for your time reviwig my work ;)

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 15, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on this sprint task, it's finished now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants