-
-
Notifications
You must be signed in to change notification settings - Fork 239
London | Sep-2025 | Gislaine Della Bella | Sprint 2 | coursework-sprint-2 #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…u define it**** Parameters are NAMES for values, not the values themselve ***
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Coursework) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Coursework) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Sprint-2/2-mandatory-debug/0.js
Outdated
| // =============> to use the function that gives a result need to use RETURN not consol.log inside the function | ||
|
|
||
| function multiply(a, b) { | ||
| const forAllMutiply = (a * b); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve this using a single line rather than 2 lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍
function multiply(num1, num2) {
return num1 * num2;
}
console.log(The result of multiplying 10 and 32 is ${multiply(10, 32)});
|
|
||
| function takeSapcestoUpercase (textSnake){ | ||
|
|
||
| let takespace = textExemple.split(" ");// returns array nned to tranform to string again before upercase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function doesn't look quite right, can you take another look?
- What happens if you call it like this:
console.log(takeSapcestoUpercase("cat dog rabbit") - There are a few spelling errors here that make it difficult to read, can you fix those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @LonMcGregor,
fixed,
thank you for your time reviwig my work ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done on this sprint task, it's finished now
Self checklist
Changelist
Hi volunteer,
Here are my Sprint 2 exercise practices.
Thank you for your time to look at my work,