Glasgow | 25-ITP-Sep | Fares Bakhet | Sprint 3 | coursework/sprint-3-stretch #763
+145
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fares-Bakhet
added
📅 Sprint 3
cjyuan
reviewed
Oct 25, 2025
Comment on lines
+32
to
+46
| // Number must be 16 digits | ||
| console.log(validateCreditCard(9999)); // false | ||
| console.log(validateCreditCard(9999888877776662)); // true | ||
|
|
||
| // Must have at least two different digits | ||
| console.log(validateCreditCard(1111111111111111)); // false | ||
| console.log(validateCreditCard(1234567890123456)); // true | ||
|
|
||
| // Last digit must be even | ||
| console.log(validateCreditCard(1234567890123451)); // false | ||
| console.log(validateCreditCard(1234567890123452)); // true | ||
|
|
||
| // Sum of all digits must be greater than 16 | ||
| console.log(validateCreditCard(1111111111111110)); // false | ||
| console.log(validateCreditCard(1234567890123456)); // true |
There was a problem hiding this comment.
Could also consider testing the boundary cases. e.g.,
- sum of digits is 16
- numbers with 15 digits
- numbers with 2 distinct digits
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-Build up functions and check them.
-Pass Jest tests.
Questions
No questions.