Glasgow | 25-ITP-Sep | Alaa Tagi| Sprint 3 | coursework/sprint 3 stretch #765
Conversation
Alaa-Tagi
changed the title
Alaa-Tagi
added
📅 Sprint 3
| test("password has at least one uppercase letter", () => { | ||
|
|
||
| const password = "1234a"; | ||
| const result = isValidPassword(password); | ||
| expect(result).toEqual(false); | ||
| } | ||
| ); |
There was a problem hiding this comment.
The function can return false for multiple reasons.
To test a specific reason, choose an input that satisfies all other conditions except the one you're targeting. This way, if the function returns false, you can confidently attribute it to that specific condition.
For example, the function might return false for "1234a" not only because it lacks an uppercase letter, but also because it lacks a special symbol.
As a result, we can't be certain that the function correctly handles the case of passwords without uppercase letters, since multiple conditions are being violated simultaneously.
cjyuan
added
Reviewed
Alaa-Tagi
added
Needs Review
There was a problem hiding this comment.
Can you make the PR description more informative (focusing on telling people what you have changed?)
In your current description:
I have created a PR with completed tasks as required.
- "have created a PR" -- This does not carry new info.
- "completed tasks" -- would be helpful to specify what the tasks are.
| test("password has at least one symbol: (!, #, $, %, ., *, &)", () => { | ||
|
|
||
| const password = "abcdA1"; | ||
| const password = "abcd12"; | ||
| const result = isValidPassword(password); | ||
| expect(result).toEqual(false); | ||
| } |
There was a problem hiding this comment.
There are two possible reasons the test could pass;
the new password does not contain any uppercase letter (in addition to not containing any symbol).
cjyuan
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
I have created a PR with completed tasks as required.
Questions
No questions.