London | 25-ITP-September | Alexandru Pocovnicu | Coursework/sprint 3 implement and rewrite #766

alexandru-pocovnicu · 2025-10-13T20:06:36Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this PR I implemented functions and rewrote tests for those functions using jest

Questions

in the number 3 get card value test,
test("should return 11 for Ace of Spades", () => {
const aceofSpades = getCardValue("A♠");
expect(aceofSpades).toEqual(11);
});
why is it necessary to declare a variable, can't we just write expect(getCardValue("A♠")).toEqual(11); instead?
thank you

…gly, created invalidCardRank function

…fractions

…function

github-actions · 2025-10-13T20:06:52Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-13T20:06:57Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-13T20:06:59Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-13T20:07:03Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-13T20:07:05Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-13T20:07:15Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

ckirby19 · 2025-10-19T21:23:21Z

Looking great! Just a few minor comments, mostly around consistency with spacing. Great job!

github-actions · 2025-10-20T18:06:03Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-20T18:33:25Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

alexandru-pocovnicu · 2025-10-20T20:48:30Z

thank you for your time @ckirby19 , can't seem to locate any of the comments

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

ckirby19 · 2025-10-19T21:19:24Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  if (Math.abs(numerator) === Math.abs(denominator) ){
+    return false;
+  }
+  if (isNaN(numerator)|| isNaN(denominator)) {


Spacing again before the ||

ckirby19 · 2025-10-20T21:40:34Z

Apologies @alexandru-pocovnicu, I sent finished my review now and sent those comments. Please let me know if you still can't see them

…ous password criteria

alexandru-pocovnicu · 2025-10-23T12:20:51Z

all good and thank you

github-actions · 2025-10-23T12:21:26Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T12:21:28Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

ckirby19 · 2025-10-25T09:25:19Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  if(numberRank>=2 && numberRank<10){
+    return numberRank;
+  }
+  if(rank==="10" || rank==="J" || rank==="Q" || rank==="K"){


Formatting: it is usually preferred to give equality checks with a space, so rank === "10" instead of rank==="10".

alexandru-pocovnicu added 7 commits October 13, 2025 07:55

completed function to get angle types and wrote the assertions for it

9dd422c

wrote assertions for extra cases and updated the function accordingly

d90591a

added assertions for cardvalue-updated getCardValue function accordin…

a447339

…gly, created invalidCardRank function

updated jest

4c94663

wrote test cases for acute, obtuse, straight, and reflex angles

b806538

created tests for identifying improper fractions and negative proper …

3143f7e

…fractions

added tests for handling number cards and face cards in getCardValue …

463d531

…function

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2025

ckirby19 added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Oct 20, 2025

ckirby19 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2025

ckirby19 reviewed Oct 20, 2025

View reviewed changes

refactor password validation logic and enhance test coverage for vari…

801f259

…ous password criteria

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 23, 2025

alexandru-pocovnicu mentioned this pull request Oct 23, 2025

ITP-2025-September | Structuring and testing data | Alexandru Pocovnicu alexandru-pocovnicu/My-Coursework-Planner#60

Open

refactor angle type checks for improved readability and consistency

fcd1c54

ckirby19 reviewed Oct 25, 2025

View reviewed changes

Uh oh!

London | 25-ITP-September | Alexandru Pocovnicu | Coursework/sprint 3 implement and rewrite #766

Are you sure you want to change the base?

London | 25-ITP-September | Alexandru Pocovnicu | Coursework/sprint 3 implement and rewrite #766

Conversation

alexandru-pocovnicu commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

ckirby19 commented Oct 19, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

alexandru-pocovnicu commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ckirby19 Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

ckirby19 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexandru-pocovnicu commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

ckirby19 Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexandru-pocovnicu commented Oct 13, 2025 •

edited

Loading

alexandru-pocovnicu commented Oct 20, 2025 •

edited

Loading

ckirby19 commented Oct 20, 2025 •

edited

Loading