West Midlands | ITP-Sept-25 | Mustaf Asani | Sprint 2 | coursework/sprint-2 #777
Conversation
asaniDev
added
the
Needs Review
cjyuan
added
Review in progress
|
|
||
| function convertToPercentage(decimalNumber) { | ||
| const decimalNumber = 0.5; | ||
| //const decimalNumber = 0.5; | ||
| const percentage = `${decimalNumber * 100}%`; | ||
|
|
||
| return percentage; | ||
| } | ||
|
|
||
| console.log(decimalNumber); |
There was a problem hiding this comment.
We could also move the declaration at line 10 outside the function without modifying the console.log statement.
Variables in different scopes can have the same name and the JS language has a set of rules to resolve "conflicting" names.
Do look up these two concepts, identifier scope and identifier resolution, in the context of JavaScript programming. ChatGPT can give a good explanation.
| } | ||
| // return the BMI of someone based off their weight and height | ||
| const bmi = weight / height ** 2; | ||
| return bmi.toFixed(1); |
There was a problem hiding this comment.
What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect?
| function formatAs12HourClock(time) { | ||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3); | ||
| console.log(minutes); |
There was a problem hiding this comment.
Code submitted to a PR should be clean. So it is best practices to not leaving any debugging statement in the code.
|
|
||
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| return `${hours - 12}:${minutes} pm`; | ||
| } | ||
| return `${time} am`; | ||
| } |
There was a problem hiding this comment.
What do you expect from the following function calls?
formatAs12HourClock("00:00");
formatAs12HourClock("01:01");
formatAs12HourClock("13:01"); Does your function return the value you expected?
cjyuan
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
finished all the tasks for coursework sprint 2