West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Coursework Sprint 2 #778
+222
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S files accordingly
…rtions to compare current output with target output
…, and write the correct code.
…fy the issue, and add the corrected code.
- Predict the behavior of the existing code and provide explanations. - Include any error messages encountered during execution. - Provide the corrected code to fix the errors.
- Predict what will happen when the program runs. - Write the correct code to fix any errors.
…, and fix the code.
… produce the expected results.
Iswanna
added
Needs Review
Iswanna
changed the title
cjyuan
added
Review in progress
cjyuan
reviewed
Oct 25, 2025
cjyuan
added
Reviewed
Hi @cjyuan. Thank you for the helpful feedback and for spotting the missing updates in the I’ve also removed the |
Iswanna
added
Needs Review
cjyuan
reviewed
Oct 26, 2025
Comment on lines
+10
to
+29
| function toPounds(penceString) { | ||
| const penceStringWithoutTrailingP = penceString.substring( | ||
| 0, | ||
| penceString.length - 1 | ||
| ); | ||
|
|
||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); | ||
| const pounds = paddedPenceNumberString.substring( | ||
| 0, | ||
| paddedPenceNumberString.length - 2 | ||
| ); | ||
|
|
||
| const pence = paddedPenceNumberString | ||
| .substring(paddedPenceNumberString.length - 2) | ||
| .padEnd(2, "0"); | ||
|
|
||
| return `£${pounds}.${pence}`; | ||
|
|
||
| // console.log(`£${pounds}.${pence}`); | ||
| } |
There was a problem hiding this comment.
The code in the function is not properly indented.
This VSCode feature might interest you:
https://code.visualstudio.com/docs/languages/javascript#_formatting
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this pull request, I completed the following:
Reviewed each file in the 1-key-errors directory, predicted the runtime errors, ran them with Node, and explained why each error occurred using the documentation.
Examined files in the 2-mandatory-debug directory, predicted why the programs were misbehaving, ran them to confirm, and corrected the code.
Implemented functions in the 3-mandatory-implement directory according to the provided requirements and tested them with multiple inputs to ensure correctness.
Analyzed larger programs in the 4-mandatory-interpret directory, researched unfamiliar syntax and functions, and used console.log to verify variable values and program flow.
Questions
Hi. Please could you review my PR? I’d really appreciate your feedback.