London | 25-ITP-SEP | Shaghayegh Shirinfar| Sprint 2 | coursework/sprint-2 #779
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module Structuring and Testing Data) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
shaghayeghfar
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
shaghayeghfar
added
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
shaghayeghfar
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
shaghayeghfar
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(0, lastSlashIndex); | ||
| const ext = base.slice(base.lastIndexOf(".")); |
There was a problem hiding this comment.
Just as an extension - how would you write this if I just wanted the extension type without the . (So txt in this case rather than .txt)?
| //Answer: line 1, 2, 6, 7 | ||
|
|
||
| // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression? | ||
| //Answer: Remove formatting commas from the price string and then convert it to a number so we can do arithmetic. |
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made : | ||
| //Answer : 5 functions |
There was a problem hiding this comment.
What are those 5 function calls? Please identify which lines these function calls are on
| // =============> write your new code here | ||
| // =============> Corrected Code: | ||
| function square(num) { | ||
| return num |
There was a problem hiding this comment.
Does this still fulfil the purpose of this function - to "square any number"?
ckirby19
added
Review in progress
|
Very nice, I just have a few questions but otherwise this looks great! |
2 participants
Learners, PR Template
Self checklist
Changelist
read the question , understand what i was asked for. answered the question and tried to fix if there were any bugs.