Skip to content

Sheffield | 25-ITP-Sep | Xiayidan Abuxuukuer | Sprint 2 | Coursework #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-ITP-Sep | Xiayidan Abuxuukuer | Sprint 2 | Coursework #781

wants to merge 10 commits into from

Conversation

@Shayida999
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Completed all required tasks for Sprint 2 coursework.
  • Implemented main functionalities and ensured the code runs correctly.
  • Applied proper formatting and style conventions for readability.

Questions

none for now thanks.

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Shayida999 Shayida999 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 18, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Shayida999 Shayida999 changed the title Sheffield | Xiayidan Abuxuukuer | Sprint 2 | Coursework Sprint2 Sheffield | Xiayidan Abuxuukuer | Sprint 2 | Coursework Oct 18, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Shayida999 Shayida999 changed the title Sheffield | Xiayidan Abuxuukuer | Sprint 2 | Coursework Sheffield | 25-ITP-Sep | Xiayidan Abuxuukuer | Sprint 2 | Coursework Oct 18, 2025
cjyuan
cjyuan reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Code and explanation look good. I only have a few suggestions.

  2. This branch is not quite clean. Can you practice using the git commands you learned to revert the changes made to the file not related to the Sprint-2 exercise?

Sprint-2/3-mandatory-implement/1-bmi.js
Comment on lines 22 to 28
function calculateBMI (weight,height) {

let bmi = weight / (height*height)

return bmi.toFixed(1)

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect?

Sprint-2/5-stretch-extend/format-time.js Outdated
Comment on lines 7 to 8
let hours = Number(time.slice(0, 2));
let mins = time.slice(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a variable is not going to be re-assigned a value, it is best practices to declare it using const instead of let (to convey the message that it is a constant and also to prevent it from being accidently reassigned a value).

Copy link
Author

@Shayida999 Shayida999 Oct 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks CJ i fixed both, and reverted sprint 1.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2025
@Shayida999 Shayida999 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 25, 2025
cjyuan
cjyuan reviewed Oct 25, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shayida999 @cjyuan