West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint 2 | Structing and Testing Data #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

zilinskyte wants to merge 12 commits into CodeYourFuture:main from zilinskyte:coursework/sprint-2

zilinskyte commented Oct 20, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Errors predicted, detected and fixed
Function implementation
Code interpreted and following questions answered

Questions


          completed

d17d9f0

github-actions bot commented Oct 20, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

zilinskyte changed the title ~~West Midlands |~~ West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint-2 | Structing and Testing Data

github-actions bot commented Oct 20, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

5 similar comments

github-actions bot commented Oct 20, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 20, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 20, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 20, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 20, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

zilinskyte changed the title ~~West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint-2 | Structing and Testing Data~~ West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint 2 | Structing and Testing Data

zilinskyte added 10 commits

October 20, 2025 01:56


          code error explained and rewritten

8d3eb4a


          Parameter defined in function


          function was not returned to global scope

516822d


          function return corrected

95b56ec


          function was calling hardcoded variable

bc05c26


          function bmi calculator written

23888b9


          returning strings in UPPER_SNAKE_CASE

b6e2da1


          refactor toPounds function for improved input handling and output for…

97e6d94

…matting


          time display formatting explained

f6b823d


          paraeter changed name

c232401

zilinskyte added Needs Review Module-Structuring-And-Testing-Data labels


          stretch - edge cases tested

7f82d29

cjyuan reviewed

View reviewed changes

Contributor

cjyuan left a comment

You have added a bunch of unrelated files zilinskyte_Module-Structuring-and-Testing-Data_ ITP 2_files... to this branch. Can you remove them from this branch to keep it clean?

Sprint-2/3-mandatory-implement/1-bmi.js

    
              function calculateBMI(weight, height) {

                  // return the BMI of someone based off their weight and height

              }

                  var bmi = (weight / (height * height));

Contributor

cjyuan Oct 25, 2025

Avoid using var to declare variables. Use let instead.

Sprint-2/3-mandatory-implement/1-bmi.js

    
                  // return the BMI of someone based off their weight and height

              }

                  var bmi = (weight / (height * height));

                  return bmi.toFixed(1);

Contributor

cjyuan Oct 25, 2025

What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect?

Sprint-2/3-mandatory-implement/3-to-pounds.js

Comment on lines +6 to +25

    
              function toPounds(penceString) {

              penceString = String(penceString);// ensures input is treated as a string even if number is inputted

              // const penceStringWithoutTrailingP = penceString.substring(

              let penceStringWithoutTrailingP = penceString;

              if (penceString.endsWith("p")) {

                  penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1);

              }   // This prevents the last characters from being sliced off if there is no p.

              const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");

              const pounds = paddedPenceNumberString.substring(

                0,

                paddedPenceNumberString.length - 2

              );

              const pence = paddedPenceNumberString

                .substring(paddedPenceNumberString.length - 2)

                .padEnd(2, "0");

              return`£${pounds}.${pence}`;

              }

Contributor

cjyuan Oct 25, 2025

Can you improve the indentation of the code in this function?

Note: In VSCode, we can install the prettier extension and then use the "Format document" function" to automatically indent code.

Sprint-2/5-stretch-extend/format-time.js

    
                if (hours > 12) {

                  return `${hours - 12}:00 pm`;

                }

                const minutes = time.slice(3);

Contributor

cjyuan Oct 25, 2025

Could also consider use time.slice(-2) to better express we are extracting the last two characters.

Sprint-2/5-stretch-extend/format-time.js

Comment on lines +15 to 17

    
                 if (hours > 12) return `${hours - 12}:00 pm`;

                return `${time} am`;

Contributor

cjyuan Oct 25, 2025

The return values of these two function calls are not formatted consistently.

console.log(formatAs12HourClock("15:30"));
console.log(formatAs12HourClock("03:30"));

Can you improve the consistency?

cjyuan added Reviewed and removed Needs Review labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data Reviewed