Gislaine Della Bella| 25-ITP- SEP | Gislaine Della Bella | Sprint 3 | Implement-and-rewrite-tests

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -8,12 +8,22 @@
 // Then, write the next test! :) Go through this process until all the cases are implemented
 
 function getAngleType(angle) {
-  if (angle === 90) {
+ if (angle === 90) {
     return "Right angle";
+  } else if (angle < 90) {
+    return "Acute angle";
+  } else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  } else {
+    return "Invalid angle"; 
   }
+}
    // Run the tests, work out what Case 2 is testing, and implement the required code here.
    // Then keep going for the other cases, one at a time.
-}
 
 // The line below allows us to load the getAngleType function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
@@ -50,14 +60,17 @@ assertEquals(acute, "Acute angle");
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
-// ====> write your test here, and then add a line to pass the test in the function above
+assertEquals( obtuse, "Obtuse angle")
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
+const straight = getAngleType(180)
+assertEquals (straight, "Straight angle");
 // Then the function should return "Straight angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+const reflex= getAngleType( 350);
+assertEquals (reflex, "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -9,7 +9,10 @@
 
 function isProperFraction(numerator, denominator) {
   if (numerator < denominator) {
-    return true;
+    return true ;
+  }
+  else {
+    return false;
   }
 }
 
@@ -38,22 +41,29 @@ assertEquals(properFraction, true);
 // Input: numerator = 5, denominator = 2
 // target output: false
 // Explanation: The fraction 5/2 is an improper fraction, where the numerator is greater than or equal to the denominator. The function should return false.
-const improperFraction = isProperFraction(5, 2);
-assertEquals(improperFraction, false);
+const properFraction2 = isProperFraction(5, 2);
+assertEquals(properFraction2, false);
 
 // Negative Fraction check:
 // Input: numerator = -4, denominator = 7
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
+assertEquals(negativeFraction, true);
 // ====> complete with your assertion
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
-// ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+
+const properFraction3 = isProperFraction(0, 6);
+assertEquals(properFraction3,true)
+
+const properFraction4 = isProperFraction(0, 1);
+assertEquals(properFraction4, true);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,8 +8,15 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  let rank = card.substring(0, card.length - 1);
   if (rank === "A") {
     return 11;
+  } else if (rank === "J" || rank === "Q" || rank === "K" || rank === "10") {
+    return 10;
+  } else if (rank >= "2" && rank <= "9") {
+    return parseInt(rank);
+  } else {
+    throw new Error("Invalid card rank.");
   }
 }
 
@@ -39,19 +46,30 @@ assertEquals(aceofSpades, 11);
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
 const fiveofHearts = getCardValue("5♥");
+assertEquals(fiveofHearts, 5);
 // ====> write your test here, and then add a line to pass the test in the function above
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
 
+const tenOfSpades = getCardValue("10♠");
+assertEquals(tenOfSpades, 10);
+
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
 
+const aceofHearts = getCardValue("A♠");
+assertEquals(aceofSpades, 11);
+
+
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+
+const invalidCard = getCardValue("87");
+assertEquals(invalidCard, "Invalid card rank");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -12,15 +12,34 @@ test("should identify right angle (90°)", () => {
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
+//else if (angle < 90) {
+//return "Acute angle";
+
+test("returns Acute angle for values less than 90 degrees",() =>{
+  expect(getAngleType(45)).toEqual("Acute angle");
+});
 
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
 
+test("returns Obtuse angle for values greater than 90 degrees and less than 180 degrees",()=>{
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+  });
+
+
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 
+test("returns Straight angle for angle === 180",() =>{
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+
+test("returns Reflex angle for angles > 180 && angle < 360",() =>{
+expect(getAngleType(290)).toEqual("Reflex angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,6 +8,28 @@ test("should return true for a proper fraction", () => {
 
 // Case 2: Identify Improper Fractions:
 
+test("it is a Improper Fraction",() =>{
+  expect(isProperFraction(3, 2)).toEqual(false);
+});
+
 // Case 3: Identify Negative Fractions:
+test("it is a Negative Fraction",() =>{
+  expect(isProperFraction(-2, 6)).toEqual(true);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+
+test("It is a equal numerator and denominador", () =>{
+  expect(isProperFraction( 2, 2)).toEqual(false);
+});
+
+
+
+// function isProperFraction(numerator, denominator) {
+//   if (numerator < denominator) {
+//     return true ;
+//   }
+//   else {
+//     return false;
+//   }
+// }

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -8,6 +8,24 @@ test("should return 11 for Ace of Spades", () => {
 });
 
 // Case 2: Handle Number Cards (2-10):
+
+test("should return number cards", () => {
+const fiveofHearts = getCardValue("5♥");
+expect(fiveofHearts).toEqual(5);
+});
+
 // Case 3: Handle Face Cards (J, Q, K):
+test ("should return Face Cards J, Q, K ", () =>{
+  const jackOfClubs = getCardValue("J♣"); 
+  expect(jackOfClubs).toEqual(10);
+});
+
 // Case 4: Handle Ace (A):
+test ("should return Ace", () =>{
+const aceofHearts = getCardValue("A♥");
+ expect(aceofHearts).toEqual(11);
+});
 // Case 5: Handle Invalid Cards:
+test("should throw 'Invalid card rank' for a rank of '1'", () => {
+  expect(() => getCardValue("1♦")).toThrow("Invalid card rank.");
+});