West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | 2 Practice TDD #798

Iswanna · 2025-10-23T21:58:47Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This pull request includes modifications to the 2-practice-tdd directory. I added test cases for the various functions in the files, and I also implemented the functions to ensure all tests pass.

Questions

Hi. Please could you review my PR? I’d really appreciate your feedback?

… string

github-actions · 2025-10-23T21:59:12Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T21:59:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T21:59:33Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-23T21:59:38Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova

hi @Iswanna! Good start on the code in this PR! There are a few things to consider while writing unit tests:

You should try to cover more test cases to see how your function behaves in different scenarios.
You should test edge cases like empty strings, undefined inputs, different data types, etc. This helps catch bugs early and makes your function more robust.

jennethydyrova · 2025-10-26T20:31:44Z

Sprint-3/2-practice-tdd/count.test.js

 // And a character char that does not exist within the case-sensitive str,
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+test("should return 0 occurence of a character", () => {


This is a good start but this is would not be considered as a good test suite as it covers just one behavior. Good test suite should cover different scenarios based on what type of arguments you pass to the function.

jennethydyrova · 2025-10-26T20:33:07Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,5 +1,12 @@
 function getOrdinalNumber(num) {


Unfortunately, this function is not passing the acceptance criteria. Please try to pass different values to the function and see if it returns what you expect.

jennethydyrova · 2025-10-26T20:33:37Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

  expect(getOrdinalNumber(1)).toEqual("1st");
 });
+
+test("should return '11th' for 11", () => {


Same as a previous comment regarding very slim test suite. Try to think of more test cases.

jennethydyrova · 2025-10-26T20:39:09Z

Sprint-3/2-practice-tdd/repeat.test.js

 // Given a target string str and a count equal to 1,
 // When the repeat function is called with these inputs,
 // Then it should return the original str without repetition, ensuring that a count of 1 results in no repetition.
+test("should return the original input with no repetition", () => {


These unit tests are good, great job on writing them! Now I would like you to think of more test cases, where the values passed to the function are not what you expected. What if you pass integer 3 as valueToRepeat or undefined as numOfTimes, etc.?

Iswanna · 2025-10-27T14:31:00Z

Hi @jennethydyrova.

Thank you so much for all the feedback. I will work on all of them and update all the necessary files.

Add a test to ensure countChar throws an error when more than one character is passed as the 'char' argument, returning a descriptive invalid input message.

…narios

…inputs

…nalNumber

…r counts and repeat strings, numbers, booleans, null, undefined, arrays, and objects

jennethydyrova

Hi @Iswanna! Really great job on writing unit tests and improving your functions. There are couple of common issues in the functions you wrote. I left comments on the countChar function but those comments are applicable to other functions as well.

You should try to return early from the function if the arguments are invalid. This makes your function much cleaner and there is really no need to execute the rest of the code if function input is invalid.
You should be throwing error or at least returning error message without assigning it to a variable that was created to hold something else. This is semantically incorrect, please try to read the function out loud and think if assigning error message to a variable that should hold something else make your function easier or harder to read.
When you find yourself repeating same code over and over again, try to think how it can be combined into more general structures or variables. Having similar if conditions can be combined into one or having multiple calculations of the same number can be saved in a variable or moved to function.

Something I want to highlight here is how you write commit messages. They are extremely clean and nicely written, really great job on it! If your were working in a team, your teammates would appreciate it a lot as it's very easy to track your changes.

jennethydyrova · 2025-10-28T15:44:11Z

Sprint-3/2-practice-tdd/count.js

 function countChar(stringOfCharacters, findCharacter) {
-  return 5
+  let characterOccurrence = "";
+  if (


It's usually better to return early if inputs are invalid, it's called early return. Can you think of a way to implement this in your function?

jennethydyrova · 2025-10-28T15:47:05Z

Sprint-3/2-practice-tdd/count.js

+    if (findCharacter.length === 1) {
+      characterOccurrence = stringOfCharacters.split(findCharacter).length - 1;
+    } else {
+      characterOccurrence = "invalid input: Input just one character";


You should be throwing error or returning error message in the cases like this. Semantically, characterOccurrence = "invalid input: Input just one character"; is incorrect because characterOccurrence is not an error, it's a variable that should hold occurrence of a certain character.

jennethydyrova · 2025-10-28T15:47:55Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

 function getOrdinalNumber(num) {
-  return "1st";
+  let ordinalNum;
+  if (Number.isInteger(num) === true) {


Same here, can you think of ways to return early if function argument is invalid?

jennethydyrova · 2025-10-28T16:01:07Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

-  return "1st";
+  let ordinalNum;
+  if (Number.isInteger(num) === true) {
+    if (


Okay, this is a good improvement on the previous version but it could be simplified a lot.

Do you need to explicitly check every single number with num % 10 === x? You are right to have a num % 100 check because it handles the 11–13 exceptions correctly, but the rest doesn't look necessary.

You could reduce repetition of the code here. Can you think of the way to not recalculate the remained for the same number over and over again?

jennethydyrova · 2025-10-28T16:09:47Z

Sprint-3/2-practice-tdd/repeat.js

+    repeatedValue = "Negative number invalid";
+  } else if(!Number.isInteger(numOfTimes)) {
+    repeatedValue = "Invalid count: count should be an integer"


This is good but you could perhaps simplify it by combining these conditions, because you simply need a positive integer as count number.

Iswanna · 2025-10-29T12:35:14Z

Hi @Iswanna! Really great job on writing unit tests and improving your functions. There are couple of common issues in the functions you wrote. I left comments on the countChar function but those comments are applicable to other functions as well.

You should try to return early from the function if the arguments are invalid. This makes your function much cleaner and there is really no need to execute the rest of the code if function input is invalid.

You should be throwing error or at least returning error message without assigning it to a variable that was created to hold something else. This is semantically incorrect, please try to read the function out loud and think if assigning error message to a variable that should hold something else make your function easier or harder to read.

When you find yourself repeating same code over and over again, try to think how it can be combined into more general structures or variables. Having similar if conditions can be combined into one or having multiple calculations of the same number can be saved in a variable or moved to function.

Something I want to highlight here is how you write commit messages. They are extremely clean and nicely written, really great job on it! If your were working in a team, your teammates would appreciate it a lot as it's very easy to track your changes.

Hi @jennethydyrova.

Thank you so much for the detailed feedback and for taking the time to review my code! I really appreciate your comments.
I’ll go through my functions again, keeping the points you mentioned in mind, and make the necessary changes.
I’m also happy you found my commit messages clear. Thank you for highlighting that.

Thanks again for the thoughtful review and guidance.

…move redundant code

…and remove redundant code

… redundant code

…ould be an integer' in Jest test case

Iswanna · 2025-10-30T10:13:38Z

Hi @jennethydyrova.

I have made corrections to all the necessary files as you suggested. Thank you so much for the detailed feedback.

github-actions · 2025-10-30T10:14:14Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova

Hi @Iswanna! Very good iteration on the last version! I left couple of comments, some of them are optional and you don't need to change anything to get your PR accepted but I think it would be useful for you to try to think of better ways of writing some parts.

jennethydyrova · 2025-10-30T10:32:28Z

Sprint-3/2-practice-tdd/count.js

+  const char = findCharacter.toLowerCase();
+
+  // Check that only one character is passed
+  if (char.length !== 1) {


This is optional but you can do this check before L10

jennethydyrova · 2025-10-30T10:33:39Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+  const lastDigit = absNum % 10;
+
+  // Handle special cases: 11th, 12th, 13th
+  if (lastTwo === 11 || lastTwo === 12 || lastTwo === 13) {


Optional again, can you think of ways to make this if condition simpler?

jennethydyrova · 2025-10-30T10:38:37Z

Sprint-3/2-practice-tdd/repeat.js

+  if (!Number.isInteger(numOfTimes)) {
+    return "Invalid count: count should be an integer";
+  }
+  if (numOfTimes < 0) {
+    return "Negative number invalid";
+  }


One more optional comment, you should try to keep your error messages consistent in style. If you say Invalid x: x must be an integer, then you should have Invalid x: x must be a positive integer. Here you might see that perhaps you can combine this if condition into something that would return Invalid x: x must be a positive integer.

jennethydyrova · 2025-10-30T10:39:01Z

Sprint-3/2-practice-tdd/repeat.js

+function repeat(valueToRepeat, numOfTimes) {
+  // Validate count
+  if (!Number.isInteger(numOfTimes)) {
+    return "Invalid count: count should be an integer";


You should ideally have your error message to mention the actual argument that is incorrect. Here you have numOfTimes but say count in the error message. This can be confusing when you try to debug your function.

I have fixed my code to reflect your correction. Thank you.

jennethydyrova · 2025-10-30T10:42:31Z

Sprint-3/2-practice-tdd/repeat.test.js

+});
+
+// case: Object input
+test("should repeat an object count times as a string", () => {


Hmm, I am not sure if you want to repeat empty object like this. I don't see value in doing so. I think the requirement of this function is to repeat string n times. If what you pass is not a string, should it perhaps return an error as you did in other functions?

Hmm, I am not sure if you want to repeat empty object like this. I don't see value in doing so. I think the requirement of this function is to repeat string n times. If what you pass is not a string, should it perhaps return an error as you did in other functions?

Hi @jennethydyrova.

I am trying to fix my code. Please, I would like your opinion. Should I let the number input (e.g. 2) repeat or return an error message?

I think the function requirement is a bit vague, that also stems from an unclear function name (this is about the importance of a good and descriptive fn names!). I would say to keep it simpler, assume that only string should be accepted as an input to be repeated, the rest should throw an error.

I think the function requirement is a bit vague, that also stems from an unclear function name (this is about the importance of a good and descriptive fn names!). I would say to keep it simpler, assume that only string should be accepted as an input to be repeated, the rest should throw an error.

Thank you for your suggestion. I agree that the function name is a bit vague. It would have been clearer if it were something like repeatString instead of just repeat. I will update the function to only allow strings to be repeated and update the tests accordingly.

jennethydyrova · 2025-10-30T10:44:46Z

Sprint-3/2-practice-tdd/count.js

+    typeof stringOfCharacters !== "string" ||
+    typeof findCharacter !== "string"
+  ) {
+    return "Invalid input: input should be a string";


It's okay to return error message like this as you are just at the beginning of learning js, but there is a better way of doing it. This is optional but can you think of how you can make use of the following https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/throw in the context of error handling in your functions?

Member

Hi @jennethydyrova.

I will read through the resource you have provided and update the code. Thank you.

You don’t need to act on optional comments right now, this one was optional, but feel free to if you’d like!

You don’t need to act on optional comments right now, this one was optional, but feel free to if you’d like!

Thank you for clarifying! I’ll keep the optional comments in mind and may try them out later to improve the code further.

Iswanna · 2025-10-30T10:57:12Z

Hi @Iswanna! Very good iteration on the last version! I left couple of comments, some of them are optional and you don't need to change anything to get your PR accepted but I think it would be useful for you to try to think of better ways of writing some parts.

Hi @jennethydyrova.
Thank you for the feedback! I’ll carefully utilise all your comments, even the optional ones, as they’ll help me improve my coding skills and think of better ways to write my code.

…: numOfTimes should be an integer"

…ger for numOfTimes; all other inputs return an error message

jennethydyrova · 2025-10-30T13:28:47Z

Great work @Iswanna!

Iswanna · 2025-10-30T13:32:29Z

Great work @Iswanna!

Thank you so much, @jennethydyrova, for the detailed feedback. It's been a great learning experience for me, and I really appreciate it.

Iswanna added 6 commits October 23, 2025 19:17

Add test for countChar when character occurs zero times

2c2b0f3

Implement countChar function to count occurrences of a character in a…

6db0981

… string

Add test cases using jest for function getOrdinalNumber

7362e86

Add the implementation for the function getOrdinalNumber

1f72b49

Add test cases using jest for the function repeat

ed1a393

Add implementation for the function repeat

93d9cb6

Iswanna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 23, 2025

Iswanna added 📅 Sprint 3 Assigned during Sprint 3 of this module Module-Structuring-And-Testing-Data The name of the module. labels Oct 23, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

jennethydyrova suggested changes Oct 26, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 26, 2025

Iswanna added 10 commits October 27, 2025 20:14

Add test to verify countChar returns 1 when the character appears once

9bc1c34

Add unit test to verify countChar returns 0 when given an empty string

01cb978

Add a test case for multi-character input in countChar

86311c7

Add a test to ensure countChar throws an error when more than one character is passed as the 'char' argument, returning a descriptive invalid input message.

Add test cases for countChar to check expected outputs in various sce…

bd7847f

…narios

Update countChar implementation to correctly count character occurrences

1c66099

Fix indentation in count.js and count.test.js

03b238e

Add test cases to ensure correct ordinal output for 12, and 13

14306cc

Fix getOrdinalNumber to handle integers correctly and reject invalid …

a6bbe86

…inputs

Add integer, negative, zero, and invalid input test cases for getOrdi…

aaa3da4

…nalNumber

Update repeat function to handle positive, zero, negative, non-intege…

4548cb5

…r counts and repeat strings, numbers, booleans, null, undefined, arrays, and objects

Iswanna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 28, 2025

jennethydyrova reviewed Oct 28, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 28, 2025

Iswanna added 5 commits October 29, 2025 23:37

Refactor countChar function to return early for invalid inputs and re…

2b82934

…move redundant code

Refactor getOrdinalNumber function to return early for invalid input …

4153632

…and remove redundant code

Fix inconsitent icode indentation

2957d4b

Refactor repeat function to return early for invalid input and remove…

95ba4bf

… redundant code

Update expected output for negative float to 'Invalid count: count sh…

d0b6378

…ould be an integer' in Jest test case

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 30, 2025

Iswanna requested a review from jennethydyrova October 30, 2025 10:23

jennethydyrova suggested changes Oct 30, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 30, 2025

Iswanna added 3 commits October 30, 2025 11:25

Update error message for numOfTimes validation to "Invalid numOfTimes…

3243748

…: numOfTimes should be an integer"

Fix function to allow only string for valueToRepeat and positive inte…

adb9421

…ger for numOfTimes; all other inputs return an error message

Update test descriptions and expected output values in test cases

f6115be

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 30, 2025

Iswanna requested a review from jennethydyrova October 30, 2025 13:26

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 30, 2025

Iswanna mentioned this pull request Oct 30, 2025

West Midlands | Structuring and testing data | Iswat Bello Iswanna/My-Coursework-Planner#94

Open

Uh oh!

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | 2 Practice TDD #798

Are you sure you want to change the base?

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | 2 Practice TDD #798

Conversation

Iswanna commented Oct 23, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iswanna commented Oct 27, 2025

Uh oh!

jennethydyrova left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iswanna commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Iswanna commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennethydyrova Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jennethydyrova Oct 26, 2025 •

edited

Loading

jennethydyrova left a comment •

edited

Loading

Iswanna commented Oct 29, 2025 •

edited

Loading

jennethydyrova Oct 30, 2025 •

edited

Loading