West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Implement and rewrite tests #800

Iswanna · 2025-10-23T22:31:41Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This pull request involves modifications to two directories:

Implement directory: I added assertions using console.assert and built the program case by case.

Rewrite-tests-with-Jest directory: I rewrote the existing test cases using Jest and ran npm test to verify the implementation of the getCardValue function.

Questions

Hi. Please could you review my PR? I’d really appreciate your feedback?

…hrow an error for invalid cards

…error

cjyuan · 2025-10-27T15:34:42Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  if (numerator < denominator && numerator !== 0) {
    return true;
+  } else if (numerator >= denominator) {
+    return false;
+  } else if (numerator === 0) {
+    return false;
  }


The function won't work properly if numerator and denominator are allowed to be negatives.
For example -3 < 2 but -3/2 is not a proper fraction.

cjyuan · 2025-10-27T15:37:25Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 function getCardValue(card) {
-  if (rank === "A") {
+  card = card.substring(0 , card.length -1); // Remove the suit emoji
+  console.log(card);


For best practices, we should ensure code submitted in a PR free of any debugging code.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

cjyuan · 2025-10-27T15:44:11Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-  if (rank === "A") {
+  card = card.substring(0 , card.length -1); // Remove the suit emoji


Why not use a separate variable rank to represents the rank of a card?

We could reuse a variable but it is better not to use the same variable to store different kinds of value.

"A♠" => represent the value of a card

"A" ==> represent the value of a rank

cjyuan · 2025-10-27T15:47:42Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+test("should identify reflex angle (>180° and <360°)", () => {
+  expect(getAngleType(250)).toEqual("Reflex angle");
+});


To make a test more robust, we could specify multiple expect(...) statements within each test() to cover multiple values that belong to the same case. For example,

test("should identify reflex angle (>180° and <360°)", () => { expect(getAngleType(300)).toEqual("Reflex angle"); expect(getAngleType(359.999)).toEqual("Reflex angle"); expect(getAngleType(180.001)).toEqual("Reflex angle"); });

cjyuan · 2025-10-27T15:49:00Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test("should return false for negative fractions", () => {
+  expect(isProperFraction(-4, 9)).toEqual(true);
+})


The test description does not quite match the test being performed.

cjyuan · 2025-10-27T15:50:00Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+test("should return the numeric value for number cards from 2 to 10", () => {
+  const numberCard = getCardValue("7♥");
+  expect(numberCard).toEqual(7);
+})


Could consider testing multiple values, especially the boundary cases "2♥" and "10♥".

Iswanna · 2025-10-28T11:01:19Z

Hi @cjyuan.

Thank you so much for all the feedback. I will work on all of them and update all the necessary files.

…expected outputs

…s; update function to handle them

…put (90.0) for right angle

… instead of "Acute angle"

…r negative numerator

…sure proper handling of invalid card ranks

Iswanna · 2025-10-29T14:51:36Z

Hi @cjyuan.

Thanks for your feedback! I’ve updated the code and tests to address all your suggestions.

cjyuan

Changes look great.

You might have misunderstood the definition of proper fraction.

cjyuan · 2025-10-29T15:22:09Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  let actualOutput;
+  // Denominator must be positive
+  if (denominator <= 0) {
+    actualOutput = false;
+  }
+  // Numerator must be positive and smaller than denominator
+  else if (numerator > 0 && numerator < denominator) {
+    actualOutput = true;
  }
+  // All other cases are not proper fractions
+  else {
+    actualOutput = false;
+  }


In math, 2/-3 equals to -2/3, and -2/-3 is equal to 2/3. So a fraction could still be considered as a proper fraction even if its denominator is negative.

-2/3 is a proper fraction.

Suggestion: Lookup the definition of proper fraction. You may also need to update the tests accordingly.

In math, 2/-3 equals to -2/3, and -2/-3 is equal to 2/3. So a fraction could still be considered as a proper fraction even if its denominator is negative.

-2/3 is a proper fraction.

Suggestion: Lookup the definition of proper fraction. You may also need to update the tests accordingly.

Hi @cjyuan.

Thank you for the clarification! You’re absolutely right. The sign of the denominator doesn’t affect whether a fraction is proper, and I should be comparing the absolute values instead.

I’ll update the function to handle negative denominators and negative numerators correctly and update the tests accordingly.

In math, 2/-3 equals to -2/3, and -2/-3 is equal to 2/3. So a fraction could still be considered as a proper fraction even if its denominator is negative.

-2/3 is a proper fraction.

Suggestion: Lookup the definition of proper fraction. You may also need to update the tests accordingly.

Hi @cjyuan.

Thank you for the clarification! You’re absolutely right. The sign of the denominator doesn’t affect whether a fraction is proper, and I should be comparing the absolute values instead.

I’ll update the function to handle negative denominators and negative numerators correctly and update the tests accordingly.

Hi @cjyuan.

I have updated the function and tests to correctly handle proper fractions with negative numerators or denominators. I also added additional test cases to ensure the function produces the expected output.
Thank you.

…erators or denominators

… negative zero, and 2/4 fraction

…rator

cjyuan

Changes made to the function isProperFraction() looks good.

The test script could use some improvement. I will mark this PR as complete first.

cjyuan · 2025-10-29T20:54:29Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

 test("should return false for negative fractions", () => {
-  expect(isProperFraction(-4, 9)).toEqual(false);
+  expect(isProperFraction(-4, 9)).toEqual(true);
 })


The test description does not quite match the test being carried out.

Could also consider testing multiple values in each test.

The test description does not quite match the test being carried out.

Could also consider testing multiple values in each test.

Hi @cjyuan.

Thank you for the feedback. I have updated the test description to match the test. I have also tested more values for each test case.

Iswanna · 2025-10-29T22:47:43Z

Changes made to the function isProperFraction() looks good.

The test script could use some improvement. I will mark this PR as complete first.

Hi @cjyuan.

Thank you so much for the detailed feedback throughout the review of my code. I really appreciate it, and it has been a valuable learning experience for me. Thank you also for marking my PR as complete.

…ith negative numerator

… negative numerator

Iswanna added 10 commits October 20, 2025 11:00

Implement getAngleType function and add assertion tests

f17635b

Add assertions to test function outputs

3766d27

Add test for when numerator is zero for stretch task

f9eea26

Update getCardValue function to return correct numerical values and t…

cfda58c

…hrow an error for invalid cards

Add and verify Jest test cases for the function

b7a2183

Include package-lock.json to ensure consistent dependency versions

f028f06

Write Jest tests to verify function behavior

fec9455

Change random number check to return a string instead of throwing an …

0032765

…error

Write Jest test cases for getCardValue function implementation

69ddec4

Add more Jest test cases for getCardValue implementation

8c717df

Iswanna added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Oct 23, 2025

cjyuan reviewed Oct 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025

Iswanna added 13 commits October 28, 2025 13:54

Update getAngleType implementation and add more test cases to verify …

028ec7d

…expected outputs

Fix inconsistent code indentation

6bcf17a

Add test cases for negative numerator/denominator and other edge case…

00515f5

…s; update function to handle them

Remove console.log debugging code from 3-get-card-value.js file

31446ec

Add test cases and update getCardValue to handle all card ranks

121ebe4

Add additional test to verify getAngleType correctly handles float in…

b46a6d3

…put (90.0) for right angle

Update getAngleType and tests to classify zero degree as "Zero angle"…

273a36a

… instead of "Acute angle"

Add more Jest test cases for acute angles in getAngleType

48f2143

Add more jest test cases for obtuse angles in getAngleType

9705d12

Add a Jest test case for straight angle in getAngleType

5c5e00b

Add more Jest test cases for reflex angles in getAngleType

a66ab62

Add Jest test case for full rotation (360°) in getAngleType

3b9f415

Add more Jest test cases for invalid angles in getAngleType

5e0b672

Iswanna added 4 commits October 29, 2025 14:20

Add test for 0 input to verify getAngleType returns 'Zero angle'

8daafbd

Change expected output from true to false in isProperFraction test fo…

050e86a

…r negative numerator

Add more Jest test cases for getCardValue to include 2 and 10

df7ccfb

Add tests for getCardValue with "1♠" and empty string arguments to en…

46aee35

…sure proper handling of invalid card ranks

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025

cjyuan reviewed Oct 29, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

Iswanna added 2 commits October 29, 2025 19:34

Change expected output to true for proper fractions with negative num…

47809af

…erators or denominators

Add edge case test cases for isProperFraction: floats, large numbers,…

cfecb6c

… negative zero, and 2/4 fraction

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025

Iswanna added 2 commits October 29, 2025 20:14

Change expected output to true for proper fraction with negative nume…

9a88261

…rator

Refactor isProperFraction to improve readability and reduce repetition

7a4e526

cjyuan reviewed Oct 29, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

Iswanna added 3 commits October 29, 2025 23:00

Change the target output in the comment to true for proper fraction w…

5411c34

…ith negative numerator

Change false to true in the test description for proper fraction with…

3b5e67d

… negative numerator

Test multiple values in each test case

bbde7ad

Uh oh!

Uh oh!

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Implement and rewrite tests #800

Are you sure you want to change the base?

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Implement and rewrite tests #800

Uh oh!

Conversation

Iswanna commented Oct 23, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iswanna commented Oct 28, 2025

Uh oh!

Iswanna commented Oct 29, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iswanna Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iswanna commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Iswanna Oct 29, 2025 •

edited

Loading