London | 25-ITP-SEP | Sophia Mohamed | Sprint 2 | coursework/sprint-2 #803

saff-coder · 2025-10-24T16:21:53Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all the exercises in Sprint-2

London | 25-ITP-Sept | Sophia Mohamed | Sprint 1 | coursework/sprint-1

The codes are fixed, the error has been corrected and explained

The prediction and explanation were done

1. Calculating the BMI 2. Change a sentence from lowercase to uppersnake case 3. Changing from Kg to lb

I run the code in Python Visualiser and answered all the questions

cjyuan

This branch is not clean -- It includes changes in the Sprint-1 folder (which is not related to Sprint-2 exercise). Can you revert the changes made in the Sprint-1 folder?

This reverts commit 7312985.

saff-coder · 2025-10-25T14:33:10Z

I reverted the commit from sprint 1

cjyuan

Good job in reverting the changes made in Sprint-1 folder.

cjyuan · 2025-10-25T14:52:40Z

Sprint-2/3-mandatory-implement/1-bmi.js

+    let bmi = 85 / (1.54 * 1.54);
+    console.log(bmi)
+   //here the result was 35.833307439446366 I need to round it to 1 decimal place
+   console.log(bmi.toFixed(1));
+   //now the output is 35.8


The objective of this exercise is to complete the implementation of the function calculateBMI() so that we can reuse the code in the function to calculate BMI for different weight and height.

I have updated the function

cjyuan · 2025-10-25T15:16:52Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+  const pounds = kg * 2.20462; 
+
+    return pounds;


This toPounds() function is supposed to convert a pence string to a string in British pounds format, like what you did in Sprint-1/3-mandatory-interpret/3-to-pounds.js

I have updated the code as required

This function converts the weight in kg to pounds

cjyuan · 2025-10-26T12:47:59Z

Sprint-2/3-mandatory-implement/1-bmi.js

+  const bmi = weight / (height * height);
+
+  // Round to 1 decimal place and return
+  return bmi.toFixed(1);


Both of these function calls output 123 in the console, but internally in the program,
the number 123 and the string "123" are stored and treated differently.

console.log(123); console.log("123");

What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

I expect the function to return a number, because a BMI is a numeric value. Yes, I tested the function, and it comes as a number.

How did you test if its return value is a number and not a string?

That's not a proper way to check the type of a value.

Can you ask AI (and then verify if needed) how to determine the type of a value in JS?

Thank you so much, that was really helpful. I used (type of )and it showed me that my output was a string, and I changed it to a number

cjyuan · 2025-10-26T12:49:16Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+  const pounds = kg * 2.20462;
+  return `${pounds.toFixed(2)} lbs`; // returns a string


This is still not what is expected.

I have changed the code, and the output is a number, not a string

This function is supposed to convert pence to British pounds (similar to what you did in Sprint-1/3-mandatory-interpret/3-to-pounds.js

I think this question is to convert the weight from kilograms to Pounds, not British pounds

What makes you think that? What does the comments (lines 1-60 in the file say?

Thank you so much for all your help

I was able to test my data type using typeof

cjyuan · 2025-10-30T17:15:43Z

Changes look good. You forgot to change the label.

saff-coder added 6 commits October 10, 2025 14:06

All the tasks are complete

7312985

Merge pull request #1 from saff-coder/coursework/sprint-1

113d089

London | 25-ITP-Sept | Sophia Mohamed | Sprint 1 | coursework/sprint-1

Key error done

c9700bf

The codes are fixed, the error has been corrected and explained

all the mandatory debug is done

f693105

The prediction and explanation were done

All the mandatory implementing done

15d0324

1. Calculating the BMI 2. Change a sentence from lowercase to uppersnake case 3. Changing from Kg to lb

Mandatory interpretation is done

3178e15

I run the code in Python Visualiser and answered all the questions

saff-coder added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 24, 2025

cjyuan reviewed Oct 25, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2025

Revert "All the tasks are complete"

a4cfc97

This reverts commit 7312985.

cjyuan reviewed Oct 25, 2025

View reviewed changes

saff-coder added 2 commits October 26, 2025 11:07

updated the code with(lbs) at the end

17480c0

This function converts the weight in kg to pounds

The BMI function is updated

d1dfef3

cjyuan reviewed Oct 26, 2025

View reviewed changes

saff-coder added 3 commits October 26, 2025 16:58

changed the function now the output is a number

cf13333

I return the result as a number

33218f8

I was able to test my data type using typeof

The code implementing is complete

03351dd

saff-coder requested a review from cjyuan October 30, 2025 16:29

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 30, 2025

		const pounds = kg * 2.20462;
		return `${pounds.toFixed(2)} lbs`; // returns a string

Uh oh!

London | 25-ITP-SEP | Sophia Mohamed | Sprint 2 | coursework/sprint-2 #803

Are you sure you want to change the base?

London | 25-ITP-SEP | Sophia Mohamed | Sprint 2 | coursework/sprint-2 #803

Conversation

saff-coder commented Oct 24, 2025

Learners, PR Template

Changelist

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

saff-coder commented Oct 25, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan commented Oct 30, 2025 •

edited

Loading