Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 2 | Coursework/sprint-2 #809

Abrsh100 · 2025-10-25T14:33:41Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have done all the tasks required for this sprint

Questions

No questions

…m the code

github-actions · 2025-10-25T14:34:03Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-25T14:36:46Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

A clean branch should not contain any unrelated change.

Change = difference between your branch and the target branch (CYF's main).

When you delete files originally in the repo (e.g., files in Sprint-1 folder), they will be identified as changed files.

To keep this branch clean, can you restore the files in the Sprint-1 folder (by copying the same files from CYF's main)?

Download the repo as a ZIP file and unzip the file to a temporary folder.
On your local repository, switch to coursework/sprint-2 branch.
Replace the Sprint-1 folder in your repo by the Sprint-1 folder in the temporary folder
Commit the change and push the change to GitHub.

cjyuan · 2025-10-27T13:19:47Z

Sprint-2/1-key-errors/0.js

-  return str;
-}
+// The error occurs in line 13 and it says "SyntaxError: Identifier 'str' has already been declared"
+// The error is informing us that the string str has already been declared in line 12 so we can not declare it again.


the string str

Calling str a "string" isn’t quite right. Try using a term that describes it as a name rather than a value.
Accurate terminology is essential for clear communication and precise reasoning about how code works.

Sprint-2/1-key-errors/1.js

cjyuan · 2025-10-27T13:38:36Z

Sprint-2/3-mandatory-implement/1-bmi.js

-function calculateBMI(weight, height) {
+function calculateBMI(weight, height) { 
+    const bmi= weight/ (height*height)
+    return bmi.toFixed(1);


What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

console.log(123); // Output 123 console.log("123"); // Output 123 // Treated differently in the program let sum1 = 123 + 100; // Evaluate to 223 -- a number let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.

cjyuan · 2025-10-27T13:41:05Z

Sprint-2/3-mandatory-implement/2-cases.js

+}
+
+console.log(toUpperCase("hello there"));
+console.log(toUpperCase("lord of the ring"));


Does this output LORD_OF_THE_RINGS?

cjyuan · 2025-10-27T13:43:01Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

 // You will need to declare a function called toPounds with an appropriately named parameter.

 // You should call this function a number of times to check it works for different inputs
+function toPounds(pennies) {


The parameter value is expected to be a string in the form "399p" (a sting with a trailing 'p').

cjyuan · 2025-10-27T13:50:28Z

Sprint-2/4-mandatory-interpret/time-format.js


 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here
+/* The value assigned to num when the pad is called for the last time is "1". */


A notation like "1" (a value enclosed by a pair of double quotes) is conventionally used to suggest the value is a string.

So use of double quotes on "00" in the previous question is good. But for a number-type value, use of double quotes could be misleading.

cjyuan · 2025-10-27T13:53:44Z

Sprint-2/5-stretch-extend/format-time.js

 function formatAs12HourClock(time) {
  const hours = Number(time.slice(0, 2));
+  if (hours===0)  {
+    return`12:00 am`
+  }
+  if (hours===12)  {
+    return `12:00 pm`
+  }
  if (hours > 12) {
    return `${hours - 12}:00 pm`;
  }
-  return `${time} am`;
+  if (hours > 0 && hours < 12)
+  return `${String(hours).padStart(2, "0")}:00 am`;
 }


Does your function return the value you expected from each of the following function calls?

formatAs12HourClock("00:31")

formatAs12HourClock("12:31")

formatAs12HourClock("01:31")

formatAs12HourClock("13:31")

cjyuan

Some of the scripts you changed has some issues. Can you test all your scripts to ensure the code in the scripts works as expected?

cjyuan · 2025-10-29T13:06:34Z

Sprint-2/3-mandatory-implement/2-cases.js

 }

 console.log(toUpperCase("hello there"));
-console.log(toUpperCase("lord of the ring"));


Does your function work for this function call? Does it output LORD_OF_THE_RING?

console.log(toUpperCase("lord of the ring"));

cjyuan · 2025-10-29T13:11:24Z

Sprint-2/5-stretch-extend/format-time.js

-  return `${String(hours).padStart(2, "0")}:00 am`;
+  const minutes = time.slice(3, 5);
+  const ampm = hours >= 12 ? "pm" : "am";
+  const Hour = String(hours % 12 === 0 ? 12 : hours % 12).padStart(2, "0")


The convention is to begin a variable name with a lowercase letter.
Name that begins with an uppercase letter is conventionally reserved for data type. For example, String.

cjyuan · 2025-10-29T13:12:50Z

Sprint-2/5-stretch-extend/format-time.js

-  }
-  if (hours > 0 && hours < 12)
-  return `${String(hours).padStart(2, "0")}:00 am`;
+  const minutes = time.slice(3, 5);


time.slice(-2) is probably more expressive (no need to calculate the starting and ending positions).

cjyuan · 2025-10-29T13:14:05Z

Sprint-2/1-key-errors/0.js

+function capitalise(firstLetters) {
+  firstLetters = `${firstLetters[0].toUpperCase()}${firstLetters.slice(1)}`;
+  return firstLetters;


Why changed str to firstLetters?

Abrsh100 added 4 commits October 11, 2025 22:14

new work space in vscode

53f9188

correctin and updating the exercise

a825bf7

Answering each question with in the file by puting // to separate fro…

d873260

…m the code

solution for sprint 2

872131a

Abrsh100 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 25, 2025

Abrsh100 added 12 commits October 26, 2025 06:44

Delete Sprint-1/1-key-exercises/1-count.js

d139163

Delete Sprint-1/1-key-exercises/2-initials.js

14f6ab7

Delete Sprint-1/1-key-exercises/3-paths.js

3ea986c

Delete Sprint-1/2-mandatory-errors/0.js

7688edc

Delete Sprint-1/1-key-exercises/4-random.js

a00d344

Delete Sprint-1/2-mandatory-errors/1.js

d336e24

Delete Sprint-1/2-mandatory-errors/2.js

5b0207b

Delete Sprint-1/2-mandatory-errors/3.js

73b25cc

Delete Sprint-1/3-mandatory-interpret/1-percentage-change.js

3c5555c

Delete Sprint-1/2-mandatory-errors/4.js

920fa0f

Delete Sprint-1/3-mandatory-interpret/2-time-format.js

eb5face

Delete Sprint-1/3-mandatory-interpret/3-to-pounds.js

f3f4e0b

cjyuan reviewed Oct 26, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

restor sprint 1 from cyf main

8448e94

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 27, 2025

cjyuan reviewed Oct 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025

correcting the errors based on your valuable comments

76ab3c7

Abrsh100 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025

cjyuan reviewed Oct 29, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

Uh oh!

Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 2 | Coursework/sprint-2 #809

Are you sure you want to change the base?

Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 2 | Coursework/sprint-2 #809

Uh oh!

Conversation

Abrsh100 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Abrsh100 commented Oct 25, 2025 •

edited

Loading

cjyuan Oct 27, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading