Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 3 |Coursework/sprint-3-practice-tdd #822
Conversation
Abrsh100
added
the
Needs Review
LonMcGregor
added
the
Review in progress
| test("should count multiple occurrences of a character", () => { | ||
| const str = "banana"; | ||
| const char = "a"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(3); | ||
| }); | ||
|
|
||
| test("should count multiple occurrences of a character", () => { | ||
| const str = "ananas"; | ||
| const char = "a"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(3); | ||
| }); | ||
|
|
There was a problem hiding this comment.
How are these two tests different from the test on lines 13-18? They are all testing "should count multiple occurrences of a character". If they belong to the same category, we could test them in the following manner:
expect( countChar("aaaaa", "a") ).toEqual(5);
expect( countChar("ananas", "a") ).toEqual(3);
...
Can you think of different cases which we could test?
|
|
||
| test("should return '2nd' for 2", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| }); | ||
|
|
||
| test("should return '3rd' for 3", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| }); | ||
|
|
||
| test("should return '11th' for 11", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| }); | ||
|
|
||
| test("should return '12th' for 12", () => { | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| }); | ||
|
|
||
| test("should return '13th' for 13", () => { | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| }); | ||
|
|
||
| test("should return '24th' for 14", () => { | ||
| expect(getOrdinalNumber(24)).toEqual("24th"); | ||
| }); |
There was a problem hiding this comment.
To ensure thorough testing, we need broad scenarios that cover all possible cases.
Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories.
Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.
For example, we can prepare a test for numbers 2, 22, 132, etc. as
test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
expect( getOrdinalNumber(2) ).toEqual("2nd");
expect( getOrdinalNumber(22) ).toEqual("22nd");
expect( getOrdinalNumber(132) ).toEqual("132nd");
});
| test("should repeat the string count times", () => { | ||
| const str = "hello"; | ||
| const count = 0; | ||
| const repeatedStr = repeat(str, count); | ||
| expect(repeatedStr).toEqual(" "); | ||
| }); |
There was a problem hiding this comment.
Can you function pass this test?
| // case: Negative Count: | ||
| // Given a target string str and a negative integer count, | ||
| // When the repeat function is called with these inputs, | ||
| // Then it should throw an error or return an appropriate error message, as negative counts are not valid. | ||
| test("should repeat the string count times", () => { | ||
| const str = "hello"; | ||
| const count = -1; | ||
| const repeatedStr = repeat(str, count); | ||
| expect(repeatedStr).toEqual("hellohellohello"); | ||
| }); |
There was a problem hiding this comment.
-
The test description does not match the case suggested in the comment.
-
Can your function pass this test?
To test if a function can throw an error as expected, you can use .toThrow(). You can find out more about how to use .toThrow() here: https://jestjs.io/docs/expect#tothrowerror (Note: Pay close attention to the syntax of the example)
cjyuan
added
Reviewed
|
@LonMcGregor Sorry. I missed the "Review in progress" label. |
cjyuan
removed
the
Review in progress
3 participants
Learners, PR Template
Self checklist
Changelist
I have made all the requerd change so that it will return properly
Questions
No questions