Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add Volume Keys & Add resetting to default in Controls #518

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TechnikTil
Copy link
Contributor

@TechnikTil TechnikTil commented Jan 4, 2025

This PR adds volume controls like Volume Up/Down/Mute to Options > Controls, and also adds a way to reset them to default.

This fixes #516/#510.

@ItsLJcool
Copy link
Contributor

Bro made my addon useless 😭

@ItsLJcool
Copy link
Contributor

but peak pr

@NexIsDumb
Copy link
Member

i feel like this should be not for coop stuff, and so only one of em is enough, am i wrong?

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Jan 5, 2025

i feel like this should be not for coop stuff, and so only one of em is enough, am i wrong?

fair ill change that rn

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Jan 5, 2025

i feel like this should be not for coop stuff, and so only one of em is enough, am i wrong?

fair ill change that rn

Actually, I cant (macro stuff)
But I think we'll be fine, cuz I'm pretty sure switch mod doesn't need p2, but here we are

@NexIsDumb
Copy link
Member

Imma see soon then

@TechnikTil
Copy link
Contributor Author

Imma see soon then

alr

@TechnikTil TechnikTil changed the title [ENHANCEMENT] Add Volume Keys to Controls. [ENHANCEMENT] Add Volume Keys and add resetting to default in Controls Jan 27, 2025
@TechnikTil
Copy link
Contributor Author

btw the resetting controls isnt here yet, just give me like an hour or so

@TechnikTil TechnikTil changed the title [ENHANCEMENT] Add Volume Keys and add resetting to default in Controls [ENHANCEMENT] Add Volume Keys & Add resetting to default in Controls Jan 27, 2025
@TechnikTil TechnikTil marked this pull request as draft February 15, 2025 22:43
@TechnikTil
Copy link
Contributor Author

forgot to do this (still being worked on)

@TechnikTil
Copy link
Contributor Author

only reason its not done is because i have no idea how macros work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Volume in Control Options
3 participants