Skip to content

fix: reconcile merged-PR XP across all installs and pages (#872) - #877

Merged
jakharmonika364 merged 1 commit into
Coder-s-OG-s:mainfrom
ionfwsrijan:fix/issue-872-reconcile-merge-xp-coverage
Aug 4, 2026
Merged

fix: reconcile merged-PR XP across all installs and pages (#872)#877
jakharmonika364 merged 1 commit into
Coder-s-OG-s:mainfrom
ionfwsrijan:fix/issue-872-reconcile-merge-xp-coverage

Conversation

@ionfwsrijan

Copy link
Copy Markdown
Contributor

Problem

reconcileMergedPrXp capped work at 50 installs and 20 repos per install, and did not paginate closed PRs, so merged PRs in larger organizations were never XP-awarded and the recompute silently under-reported totals.

Fix

  • Removed the install/repo caps; all active installs are scanned, every repo per install.
  • Closed-PR queries are paginated (descending by updated) while the newest updated_at still falls inside the 7-day window, bounded by RECONCILE_MAX_PAGES=10.

Files changed

  • src/inngest/functions/maintenance.ts
  • Test: src/inngest/functions/maintenance.test.ts

Testing

  • Full MergeShip suite passes.
  • New pagination test asserts a page-2 merged PR is awarded XP.

Closes #872

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@ionfwsrijan is attempting to deploy a commit to the codersogs-3057's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Hey @ionfwsrijan

You have 4 open PRs right now. The limit is 3 at a time.

Please get your existing PRs merged or closed before opening new ones:

This PR will remain open but won't be reviewed until you're under the limit. See our Contributing Guidelines for details.

@ionfwsrijan

Copy link
Copy Markdown
Contributor Author

@jakharmonika364 @Soumya-codr Please review this

@jakharmonika364 jakharmonika364 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jakharmonika364
jakharmonika364 merged commit 5e2465d into Coder-s-OG-s:main Aug 4, 2026
3 of 4 checks passed
@ecsoc-sentinel ecsoc-sentinel Bot added ECSoC26-L2 Medium and removed ECSoC26-L3 Hard labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants