Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation split into partial class system. #20

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Translation split into partial class system. #20

merged 2 commits into from
Oct 2, 2022

Conversation

CollinMcKinney
Copy link
Owner

No description provided.

@CollinMcKinney CollinMcKinney self-assigned this Oct 2, 2022
@CollinMcKinney
Copy link
Owner Author

Translation.cs has become Translation.Designer.cs, with partial classes for each language (currently Translation.English.cs, Translation.German.cs, and Translation.Spanish.cs)

@CollinMcKinney CollinMcKinney linked an issue Oct 2, 2022 that may be closed by this pull request
Translation class should be converted to a partial class. #19
Closed
CollinMcKinney
CollinMcKinney commented Oct 2, 2022
View reviewed changes
Copy link
Owner Author

@CollinMcKinney CollinMcKinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a formatting (whitespace) error, ignore that as it does not affect compilation. Will look into auto formatting rules at some point.

@RyadaProductions
Copy link
Collaborator

RyadaProductions commented Oct 2, 2022 •
edited
Loading

Looks good on first glance. Although I would personally rename Translation.Designer.cs to Translation.cs
Designer.cs is generally used for auto generated files from visual studio that have a visual designer, so to me it doesn’t make sense that it’s on a code only file.

@CollinMcKinney
Copy link
Owner Author

My thought with the .Designer.cs naming was that since it is the base implementation of a partial class, it should receive that name. But now I think you're right that it should have the .Designer dropped from the name for clarity purposes.

CollinMcKinney
CollinMcKinney commented Oct 2, 2022
View reviewed changes
Copy link
Owner Author

@CollinMcKinney CollinMcKinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation.Designer.cs has been (re)renamed to Translation.cs with latest commit.

CollinMcKinney
CollinMcKinney commented Oct 2, 2022
View reviewed changes
Copy link
Owner Author

@CollinMcKinney CollinMcKinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and merge it and delete the cleanup branch.

A new "electron" branch was created where the project will be rewritten using ElectronNET.

Imagery and core source-code has been copied over; more language support could be added to Translation for now, but most of the other code should be considered stale, and no need for further cleanup.

@CollinMcKinney CollinMcKinney merged commit 3d33cf1 into master Oct 2, 2022
@RyadaProductions
Copy link
Collaborator

Was unable to have jnternet today after I send my initial suggestion but it looks good to me now. :) so no complaints about the merge.

I’ll have a look at the electron branch tomorrow

@CollinMcKinney CollinMcKinney deleted the cleanup branch October 9, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyadaProductions RyadaProductions Awaiting requested review from RyadaProductions

Assignees

@CollinMcKinney CollinMcKinney

Labels
None yet
Projects
None yet
Milestone
Directory of partial classes for diff...
Development

Successfully merging this pull request may close these issues.

Translation class should be converted to a partial class.
2 participants
@CollinMcKinney @RyadaProductions