fix(GithubApi): 修复 release 分支过滤 + 错误信息校验#67
Open
Colorful-glassblock wants to merge 1 commit intolastAndroid5from
Open
fix(GithubApi): 修复 release 分支过滤 + 错误信息校验#67Colorful-glassblock wants to merge 1 commit intolastAndroid5from
Colorful-glassblock wants to merge 1 commit intolastAndroid5from
Conversation
- getReleases() 原逻辑将 targetCommitish 与字符串 "develop" 直接比较， targetCommitish 实际存储的是 commit SHA，恒不匹配，导致 filter 永远返回空 - 新增 getAllReleases() 负责纯 API 拉取，getBranchHeadSha() 解析分支 HEAD SHA - getReleases() 改用与 getBranchHeadSha(CURRENT_BRANCH) 的比较结果过滤 - 分支 HEAD SHA 解析失败时降级（不分支过滤），避免网络异常直接炸 - getLatestPreReleaseBuild() 加 page <= 10 上限防止极端情况无限循环
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
与 develop 侧 PR #65 相同的修复，仅 CURRENT_BRANCH 改为 lastAndroid5。必须先合并此 PR 才能让 lastAndroid5 版本的检查更新恢复正常。