Apply warmup penalty to shots in darkness

[Keshash]

Additions

Describe new functionality added by your code, e.g.

• Increases warmup time when shooting in darkness. 100% darkness gives +100% warmup time (with the current curve). Uses the same method as the accuracy penalty to calculate this.

• Night vision reduces this penalty.

• Does not apply to launchers that don't require line of sight (i.e. mortars)

• Togglable in mod settings, off by default

• Doesn't work for turrets, but subsequent shots also don't work for turrets currently and they both should apply at the same time. Related issue: [Bug]: Subsequent shots don't apply to turrets on Snapshot and Suppressive. #3886

References

Links to the associated issues or other related pull requests, e.g.

• Impactfulness will need to be tested again after Dark Matters #3756 is merged.

Reasoning

Why did you choose to implement things this way, e.g.

• When shooting at night, it's not only difficult to aim at the correct place, it's also hard to figure out where your enemy is right now. So, we adding some time to aiming doesn't seem out of place.
• Even with accuracy penalties, nighttime doesn't seem impactful. However, reducing accuracy even further will cause pawns to shoot at weird angles and unrelated places. Increasing warmup time is a more fun alternative to that.
• This will indirectly buff melee by giving pawns more time to run up and melee lock the shooter.
• Building NVGs and using flares will be more rewarding. Those who have NVGs or power armor will be able to alpha strike those who don't, even with identical weapons and skills.
• Using flares takes a lot of time. This compensates time spent by reducing aiming time for later shots.
• This is most impactful on high aiming time weapons, like binoculars and rocket launchers, encouraging users of those to also carry a flare gun.
• +100% sounds like a lot, but in testing it seems ok, especially with subsequent shots on. If it will prove to be too much, i'd propose to reducing it to +50% max.
• Does not apply to overhead launchers like mortars, because they wouldn't need to look at the target anyway. Also makes flare gun ignore this system.

Alternatives

Describe alternative implementations you have considered, e.g.

• Make it half as impactful.

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• (For compatibility patches) ...with and without patched mod loaded
• Tested all vanilla, CE Guns and Armory weapons, work as intended.
• Playtested a colony (specify how long)
• In the process of playing a colony to test this

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15003110169.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15122313420.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15137956224.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-15138114283.zip

[Keshash]

ahhh, i messed something up big time. will open a new pr instead

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-16167424262.zip