Skip to content

Vf damage fix#4586

Merged
N7Huntsman merged 14 commits into
Developmentfrom
vf-damage-fix
Jun 4, 2026
Merged

Vf damage fix#4586
N7Huntsman merged 14 commits into
Developmentfrom
vf-damage-fix

Conversation

@perkinslr

@perkinslr perkinslr commented May 12, 2026

Copy link
Copy Markdown
Contributor

Additions

  • projectiles leaving vehicles spawn fragments
  • mod option to make all components reachable

Changes

  • vehicles die when all reachable components are destroyed

Reasoning

Currently, some vehicles are nearly unkillable, when they have an external component that can never be hit due to not being on the vehicle perimiter. This resolves that in either of 2 ways, depending on player setting. Both have edge cases involving the AI.

Alternatives

Force one choice.
Let some vehicles remain effectively immortal.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners May 12, 2026 06:55
@perkinslr perkinslr marked this pull request as draft May 12, 2026 06:55
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-25718627213.zip

@github-actions github-actions Bot added the Download in Comments This PR has a zipfile download available. label May 12, 2026
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-25718777580.zip

@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26695571284.zip

@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26695700776.zip

@perkinslr perkinslr marked this pull request as ready for review May 31, 2026 00:27
@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26698913096.zip

ViralReaction
ViralReaction requested changes May 31, 2026
View reviewed changes
Comment thread Source/CombatExtended/CombatExtended/ModSettings/Settings.cs Outdated
Comment thread Source/VehiclesCompat/VehiclesCompat/VehicleSettings.cs Outdated
Comment thread Source/VehiclesCompat/VehiclesCompat/VehicleArmorPatch.cs Outdated
@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26701127304.zip

ViralReaction
ViralReaction previously approved these changes May 31, 2026
View reviewed changes
@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26726972643.zip

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26777151891.zip

ViralReaction
ViralReaction previously approved these changes Jun 2, 2026
View reviewed changes
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26922456522.zip

@N7Huntsman N7Huntsman merged commit 375fc89 into Development Jun 4, 2026
3 checks passed
@N7Huntsman N7Huntsman deleted the vf-damage-fix branch June 4, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

@ViralReaction ViralReaction ViralReaction left review comments

Assignees

No one assigned

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@perkinslr @N7Huntsman @ViralReaction