Skip to content

Better Grenade Handling harmony patch#4608

Merged
N7Huntsman merged 8 commits into
Developmentfrom
bgh-harmony-patch
Jun 4, 2026
Merged

Better Grenade Handling harmony patch#4608
N7Huntsman merged 8 commits into
Developmentfrom
bgh-harmony-patch

Conversation

@Safairette

@Safairette Safairette commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Additions

  • Patches BGH's EMP check to skip the IsFlesh check, as CE makes flesh also take EMP damage.

References

Reasoning

  • Better to patch the mod's behavior than drastically change our projectile stats to account for it.

Alternatives

  • Move on with the projectile changes.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@Safairette Safairette requested review from a team as code owners June 2, 2026 16:40
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26834127682.zip

@github-actions github-actions Bot added the Download in Comments This PR has a zipfile download available. label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26834244567.zip

perkinslr
perkinslr previously approved these changes Jun 2, 2026
ViralReaction
ViralReaction previously approved these changes Jun 2, 2026

@ViralReaction ViralReaction left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine

@HomerN2763

Copy link
Copy Markdown

Thanks, I wasn't able to find the issue in BGH

@N7Huntsman N7Huntsman dismissed stale reviews from ViralReaction and perkinslr via 7e9e58f June 3, 2026 03:45
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26862406130.zip

@N7Huntsman

Copy link
Copy Markdown
Contributor

Getting some yellow warning messages on start up with BGH + CE, but the target selection for EMP shotgun shells appears to be working as intended. https://pastebin.com/CADPedVv

If someone can check those warnings and either resolve them or verify they're of no concern, I'll approve.

@ViralReaction ViralReaction left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the errors are being caused by the patch being called too early and causing DefOf references errors due to how BGH is coded. The patch will need to fire later than normally from pathcAll

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26877227255.zip

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26877408999.zip

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26878129041.zip

@ViralReaction ViralReaction dismissed their stale review June 4, 2026 00:34

Issue has been corrected

ViralReaction
ViralReaction previously approved these changes Jun 4, 2026

@ViralReaction ViralReaction left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but should require a LoadAfter to prevent a warning from BGH that will confuse users

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-26922370685.zip

@N7Huntsman N7Huntsman merged commit ac77be6 into Development Jun 4, 2026
3 checks passed
@N7Huntsman N7Huntsman deleted the bgh-harmony-patch branch June 4, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants