Skip to content

Fix Shield Secondary Damage Calculation#4609

Open
ViralReaction wants to merge 2 commits into
Developmentfrom
Fix-Shield-Secondary-Damage
Open

Fix Shield Secondary Damage Calculation#4609
ViralReaction wants to merge 2 commits into
Developmentfrom
Fix-Shield-Secondary-Damage

Conversation

@ViralReaction

@ViralReaction ViralReaction commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Fixes math for secondary damage
  • Remove dinfo.Amount modification

Reasoning

Why did you choose to implement things this way, e.g.

  • Secondary damage was being added twice to total value
  • Default dinfo value is fine enough for determining fleck amount to create on shield absorb

Alternatives

Describe alternative implementations you have considered, e.g.

  • Bad math

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@ViralReaction ViralReaction requested review from a team as code owners June 5, 2026 15:53
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-27025211736.zip

@github-actions github-actions Bot added the Download in Comments This PR has a zipfile download available. label Jun 5, 2026
@ViralReaction ViralReaction changed the title Remove dinfo modification Fix Shield Secondary Damage Calculation Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-27025379138.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants