add minValue to bulk#4617
Merged
N7Huntsman merged 2 commits intoJun 15, 2026
Merged
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-27415209159.zip |
github-actions
Bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-27417732781.zip |
N7Huntsman
approved these changes
Jun 15, 2026
N7Huntsman
merged commit 60a8e9f
into
CombatExtended-Continued:Development
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
No real additions
Changes
add minValue to Carry bulk to fix 0 or negative bulk percent will under flow melee damage
References
bug chat
https://discord.com/channels/278818534069501953/324222101550661663/1513549904679796918
Reasoning
no C# cause XML fixes the issue
Alternatives
C# number check that will do the same thing in the end but more testing
Testing
Check tests you have performed: