implement Redis-based rate limiting with fail-closed security#56
Open
mnah05 wants to merge 2 commits intoComeOnOliver:mainfrom
Open
implement Redis-based rate limiting with fail-closed security#56mnah05 wants to merge 2 commits intoComeOnOliver:mainfrom
mnah05 wants to merge 2 commits intoComeOnOliver:mainfrom
Conversation
Replace in-memory rate limiter with Upstash Redis for production persistence. Changes: - Add @upstash/redis dependency for distributed rate limiting - Replace Map-based storage with Redis INCR/EXPIRE operations - Implement fail-closed: return 503 if Redis unavailable (security) - Add standard rate limit headers: X-RateLimit-Limit, Remaining, Reset - Return 429 with Retry-After when limit exceeded Closes ComeOnOliver#15
|
@mnah05 is attempting to deploy a commit to the Pengzhou AI CLUB Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@ComeOnOliver just checking if you have reviewed this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the broken in-memory rate limiter with Upstash Redis for production-grade rate limiting. The previous implementation reset on each serverless invocation, allowing unlimited abuse.
Problem
X-RateLimit-*headers present in responsesSolution
X-RateLimit-Limit,X-RateLimit-Remaining,X-RateLimit-ResetRetry-Afterheader when limit exceeded