Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 20, 2025

Summary

Adds a pre-commit safeguard that reshuffles staged Vue files into our desired block order before linting, helping us adopt the pattern without touching the whole repo yet. After a while, we can merge the followup:

Changes

  • Hook Updated lint-staged.config.js so staged .vue files pass through eslint --fix with the docs → script → template → i18n → style block-order rule.
  • Flow Kept the existing format + lint + typecheck steps, ensuring the new hook just adds ordering on top of the current pipeline.

Review Focus

  • Validate the lint-staged command syntax (particularly the quoting around the inline rule).
  • Confirm the hook only targets staged Vue files and leaves TS/JS handling unchanged.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner September 20, 2025 05:11
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 20, 2025
Copy link

github-actions bot commented Sep 20, 2025

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 09/20/2025, 05:53:09 AM UTC

📈 Summary

  • Total Tests: 454
  • Passed: 425 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 418 / ❌ 0 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne force-pushed the chore/vue-block-order-precommit branch from ea01674 to ed9e8a2 Compare September 20, 2025 05:33
@christian-byrne
Copy link
Contributor Author

This is actually not necessary because we have an action that automatically applies lint fixes to commits - so I think we are good to close this and just merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer experience size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant