[feat] Improve group title layout #5774
Open
+14
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove NODE_TEXT_SIZE, NODE_SUBTEXT_SIZE, and GROUP_TEXT_SIZE from all palette JSON files - Make font sizes hardcoded constants in LiteGraphGlobal instead of theme-configurable - Remove font_size from group serialization/deserialization to prevent workflow overrides - Update schemas and tests to reflect font size removal from themes - Ensure themes only contain colors, making them the single source of truth for colors only This change prevents themes and saved workflows from overriding font sizes, ensuring consistent typography controlled by hardcoded constants. Also prevents layout issues if the font sizes are changed from the default.
- Reduce GROUP_TEXT_SIZE from 24 to 20px for better proportions - Use NODE_TITLE_HEIGHT (30px) for group title area height consistently - Center text vertically in title area with left padding (font_size / 2) - Update LGraphCanvas header height calculation to use NODE_TITLE_HEIGHT - Update test snapshots to reflect new GROUP_TEXT_SIZE value This gives more whitespace around group titles and fixes the odd group title height of ~3.3 grid units
dosubot
bot
added
the
size:M
🎭 Playwright Test Results
⏰ Started at: 09/25/2025, 08:30:49 PM UTC 🚀 Running Tests
⏱️ Please wait while tests are running... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Summary
Changes Made
First commit - Remove font sizing from themes:
This change prevents themes and saved workflows from overriding font sizes, ensuring consistent typography controlled by hardcoded constants. Also prevents layout issues if the font sizes are changed from the default.
Second commit - Update group title layout:
This gives more whitespace around group titles and fixes the odd group title height of ~3.3 grid units
Test Plan
Screenshots
Before
After
┆Issue is synchronized with this Notion page by Unito