feat(cli): --ack summary|full on workflow apply (default full; pinned summary shape)

[skishore23]

Implements Linear BE-7149 (ticket V1-012).

comfy workflow apply echoes the full ops array back in the success envelope. The sender already has the batch it sent, so for a large batch the echo is pure transcript weight. This adds --ack summary|full to apply.

Pinned summary shape

--ack summary returns exactly (field names feed the cloud field-contract manifest — add/rename only with a contract bump on that side):

{
  "count": 4,
  "ops_by_kind": {"add_node": 2, "connect": 1, "set_widget": 1},
  "nodes_added": [3504687186153845, 1916471524889913],
  "nodes_deleted": [],
  "aliases": {"ckpt": 3504687186153845, "pos": 1916471524889913},
  "base_version": 0,
  "version": 4,
  "changed": true
}

No ops echo. changed and version bookkeeping (base_version, version = base_version + len(ops)) are computed identically in both modes; the envelope-level changed flag is unchanged.

Live smoke (temp project, offline catalog):

$ comfy --json workflow apply wf.json --ops ops.json --ack summary --input sd15_object_info.json
{"schema": "envelope/1", "type": "envelope", "ok": true, "command": "workflow apply", "version": "0.0.0", "where": null, "data": {"count": 4, "ops_by_kind": {"add_node": 2, "connect": 1, "set_widget": 1}, "nodes_added": [3504687186153845, 1916471524889913], "nodes_deleted": [], "aliases": {"ckpt": 3504687186153845, "pos": 1916471524889913}, "base_version": 0, "version": 4, "changed": true}, "error": null, "changed": true}

Pretty mode renders the summary as per-kind counts + alias lines under the existing ✓ applied N edit(s) line.

Default unchanged (proof)

The default (no flag) payload is byte-identical to today's, and --ack full is an explicit synonym: test_apply_ack_default_byte_identical pins the only nondeterminism in the apply path (node ids via mint_id/random.getrandbits, op ids via uuid.uuid4; layout is documented "no randomness, no clock", the CRDT stamp is [base_version, actor]) to counters, runs the same batch on the same file path with and without --ack full (resetting file content + counters in between), and byte-compares the envelope lines. It additionally pins the default payload to today's exact key set ({workflow, count, ops, aliases, base_version, version, wrote}) with the full per-op echo.

Partial-failure semantics

The batch stays atomic (op k of n fails → abort, nothing written). --ack never changes the outcome: both modes keep error.code = workflow_edit_invalid and exit 1. Summary mode only ADDS a structured receipt to error.details:

{"failed": {"index": 1, "op": "add_node", "code": "workflow_edit_invalid"}, "applied_count": 1}

failed.index is 0-based (matching the existing spec #N message convention); applied_count counts specs applied before the abort — all discarded, per the atomic batch. Default mode's failure envelope is unchanged (details: null, pinned by test_full_mode_failure_envelope_unchanged). To carry the failing spec's position out of workflow_ops.apply_specs, the batch-level wrap now stamps spec_index/spec_op/applied_count attributes on the wrapped ValueError (message and type unchanged).

foreach deliberately takes no --ack: its payload never echoed ops ({recipe, count, out_dir, written}), so there is nothing to summarize.

Sibling-PR rebase notes

Two sibling drafts sit on this same base branch:

• docs+ops: freeze the op vocabulary (op-vocabulary-v1.md) + $-alias sugar + batch-clear hint #704 (touches workflow_ops.py, error_codes.py, and workflow_edit.py's NotBatchableError catch): this PR edits the tail of workflow_ops.apply_specs (the except (ValueError, KeyError) wrap) and apply_cmd's batch-failure except block in workflow_edit.py — if docs+ops: freeze the op vocabulary (op-vocabulary-v1.md) + $-alias sugar + batch-clear hint #704's NotBatchableError catch lands on the same except in apply_cmd, whichever merges second needs a manual rebase of that block (keep both the structured details receipt and the new catch). No new error codes here, so error_codes.py is untouched.
• feat(cli): --select projection on the heavy four (one selector, fail-open, selected/total_bytes) #705 (touches renderer.py extra param, error_codes.py): no overlap — this PR does not modify renderer.py or error_codes.py.

Test evidence

New tests/comfy_cli/command/test_ack_flag.py, written red-first (6 failed / 3 baseline-passed before the implementation; 9 passed after):

• test_apply_ops_ack_summary_returns_counts_and_aliases — 3-op batch with as: aliases → exact pinned key set, "ops" not in data
• test_ack_summary_reports_deleted_nodes — nodes_deleted carries real ids
• test_ack_rejects_unknown_value — --ack bogus → workflow_edit_invalid
• test_apply_ack_default_byte_identical — see proof above
• test_ack_summary_partial_failure_reports_index_and_code — op 2 of 3 invalid → failed == {index: 1, op: "add_node", code: "workflow_edit_invalid"}, applied_count == 1, file untouched
• test_full_mode_failure_envelope_unchanged
• test_single_edit_verbs_unaffected + test_single_edit_verbs_do_not_take_ack
• test_pretty_summary_renders_counts_and_aliases

Verification run:

• uv run pytest tests/comfy_cli/command/test_workflow_edit.py tests/comfy_cli/command/test_ack_flag.py tests/comfy_cli/command/test_workflow_apply_rollback.py tests/comfy_cli/output/test_error_code_registry.py -q → 115 passed (includes the error-code registry gate)
• Full suite: 4584 passed, 29 failed, 38 skipped — all 29 failures (test_logs/test_jobs/test_onboarding/test_host_port/restore_snapshot) reproduce identically at the base commit with this change stashed; pre-existing on fix/validate-lowers-ui-to-api, unrelated.
• ruff check + ruff format --check clean on the three changed files.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fef3449c-62c1-414d-8fa5-cbf4d8226a0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}