Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use basePath from config.json as the desktop install location #750

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Use basePath from config.json as the desktop install location #750

merged 4 commits into from
Jan 28, 2025
+15 −49

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 28, 2025 •
edited by sync-by-unito bot
Loading

The desktop app base path is now concretely set in config.json. The value in extra models config is used exclusively for ComfyUI core model / custom_nodes locations.

  • No impact for users upgrading from 0.4.13
  • Will trigger maintenance page with an invalid base path for users that meet all of the following criteria:
    • Upgrading from versions 0.4.0 - 0.4.12
    • Manually edited the old desktop-specific base_path in the desktop YAML config
    • Did not update config.json to match
    • Moved the actual ComfyUI installation folder

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested review from a team as code owners January 28, 2025 16:45
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 28, 2025
@huchenlei
Add readonly

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
a72c1f5
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 28, 2025
@huchenlei huchenlei merged commit 4b1e906 into main Jan 28, 2025
6 checks passed
@huchenlei huchenlei deleted the use-desktop-basepath branch January 28, 2025 18:14
@huchenlei huchenlei mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DevTask] Move base path to desktop app config
2 participants
@webfiltered @huchenlei