Skip to content

Disable Deno tests to unblock clean CI #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Alirexaa
Copy link
Member

@Alirexaa Alirexaa commented Jan 14, 2025

Related issue: #377

Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.EventStore 100% 100% 46
CommunityToolkit.Aspire.Hosting.ActiveMQ 60% 24% 104
CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit 1% 0% 14
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 22
CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps 100% 100% 28
CommunityToolkit.Aspire.Hosting.Bun 81% 71% 54
CommunityToolkit.Aspire.Hosting.Deno 84% 75% 72
CommunityToolkit.Aspire.Hosting.EventStore 90% 71% 62
CommunityToolkit.Aspire.Hosting.Golang 94% 50% 16
CommunityToolkit.Aspire.Hosting.Java 98% 71% 58
CommunityToolkit.Aspire.Hosting.Meilisearch 61% 27% 94
CommunityToolkit.Aspire.Hosting.Ngrok 59% 50% 58
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions 90% 68% 92
CommunityToolkit.Aspire.Hosting.Ollama 65% 64% 198
CommunityToolkit.Aspire.Hosting.Python.Extensions 67% 46% 56
CommunityToolkit.Aspire.Hosting.Rust 94% 83% 16
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects 75% 61% 96
CommunityToolkit.Aspire.MassTransit.RabbitMQ 100% 100% 30
CommunityToolkit.Aspire.Meilisearch 97% 92% 68
CommunityToolkit.Aspire.OllamaSharp 87% 82% 68
Summary 76% (2457 / 3254) 62% (610 / 976) 1252

Minimum allowed line rate is 60%

@Alirexaa Alirexaa requested a review from aaronpowell January 14, 2025 21:28
@aaronpowell
Copy link
Member

I'm not sure this is a good idea. Since Deno seems to be broken, disabling the tests gives a false indication that the integration is usable, when it appears not to be (the Deno sample fails to launch).

@Alirexaa
Copy link
Member Author

I'm not sure this is a good idea. Since Deno seems to be broken, disabling the tests gives a false indication that the integration is usable, when it appears not to be (the Deno sample fails to launch).

I know that but other PRs CI failed due to this. We should unlock the PRs by disabling these tests just for now.

@aaronpowell
Copy link
Member

I've tagged you on #391 which is a better fix - even if it's also a temporary workaround.

@Alirexaa Alirexaa mentioned this pull request Jan 14, 2025
@Alirexaa
Copy link
Member Author

Alirexaa commented Jan 14, 2025

Close for favor of #391

@Alirexaa Alirexaa closed this Jan 14, 2025
@Alirexaa Alirexaa deleted the alirexaa/disable-deno-tests branch January 14, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants