Fix version format for weekly release tags #748
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Weekly release packages have malformed version suffixes due to incorrect
VERSION_PROPERTY
logic in the build workflow.Example from run 18109399189 (Sept 29, 2025):
CommunityToolkit.Labs.WinUI.Controls.Shimmer.0.1.250929-pull-.2302.nupkg
CommunityToolkit.Labs.WinUI.Controls.Shimmer.0.1.250929-build.2302.nupkg
All 12 packages in the Sept 29 weekly release run had the malformed
pull-.RUNNUMBER
suffix instead of the correctbuild.RUNNUMBER
format.Root Cause
The
VERSION_PROPERTY
environment variable inbuild.yml
uses conditional logic to determine version suffix format:This condition checks:
main
orrel/*
branch → usebuild.RUNNUMBER
pull-PRNUMBER.RUNNUMBER
Weekly release tags have refs like
refs/tags/release/weekly/250929
, which don't match either condition, so they fall through to the pull request format. Sincegithub.event.number
is null for tag pushes, the result ispull-.RUNNUMBER
.Solution
Add tag detection to the condition so release tags use the same format as main branch builds:
This change is applied in both the
build
job (line 85) andpackage
job (line 269) to ensure consistent version formatting throughout the workflow.Testing
This fix can be validated:
scheduled-releases
workflow manually via Actions UIbuild.RUNNUMBER
suffix instead ofpull-.RUNNUMBER
Related
Evidence
Downloaded artifacts from run 18109399189 confirmed all packages had malformed version suffix. Example packages affected: CanvasLayout, CanvasView, DataTable, MarkdownTextBlock, Marquee, OpacityMaskView, Shimmer, TitleBar, TokenView, DependencyPropertyGenerator, RivePlayer, TransitionHelper.