pwquality and pwhistory fixes #14095
Merged
+382
−236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SLE16 platform those files reside in different than default location and this might be the case for other future platforms
teacup-on-rockingchair
added
Ansible
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
No need for jinja condition if we use platform condition
teacup-on-rockingchair
force-pushed
the
pwquality_pwhistory_file_use_var
branch
from
df4309e to
9361d6f
Compare
teacup-on-rockingchair
requested review from
a team,
Mab879,
jan-cerny,
matusmarhefka and
vojtapolasek
as code owners
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Mab879
approved these changes
Nov 19, 2025
Member
Mab879
left a comment
Mab879
left a comment
There was a problem hiding this comment.
Just a couple nitpicks, other that looks good.
...s-pam/password_quality/password_quality_pwquality/accounts_password_pam_retry/bash/shared.sh
Outdated
Show resolved
Hide resolved
...-pam/password_quality/password_quality_pwquality/accounts_password_pam_retry/oval/shared.xml
Outdated
Show resolved
Hide resolved
Xeicker
approved these changes
Nov 19, 2025
…assword_quality_pwquality/accounts_password_pam_retry/bash/shared.sh Co-authored-by: Matthew Burket <[email protected]>
…assword_quality_pwquality/accounts_password_pam_retry/oval/shared.xml Co-authored-by: Matthew Burket <[email protected]>
|
@teacup-on-rockingchair: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
teacup-on-rockingchair
merged commit a20bb6d
into
ComplianceAsCode:master
137 of 140 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale: