Skip to content

Conversation

@a-skr
Copy link
Contributor

@a-skr a-skr commented Nov 20, 2025

Description:

  • add debian support for audit_rules_networkconfig_modification

Rationale:

  • Debian based OS don't have an /etc/sysconfig directory.

Review Hints:

  • Debian OVAL check file is a symlink to ubuntu check.
  • My initial intention was to factor Debian and Ubuntu check in a debian-family.j2 file and use jinja include directives to import the common parts both from ubuntu.xml and debian.xml, but the oval rule directory is currently not in the jinja template path.
  • As ubuntu check is compatible with debian, I just used a symlink instead.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

Hi @a-skr. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@a-skr a-skr force-pushed the debian13-20251120 branch from 72f1bd6 to eefda01 Compare November 21, 2025 12:40
@Mab879 Mab879 added this to the 0.1.80 milestone Nov 21, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think is fine, but you need update stable products. See the failing Debian CI for more details.

@a-skr
Copy link
Contributor Author

a-skr commented Nov 22, 2025

I will update them. I was never sure of whether I shall update them by hand, or if they are automatically updated as part of a later release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants