-
Notifications
You must be signed in to change notification settings - Fork 173
Added some production-default recommendations #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I had copilot do a few PR's, so no problem with that, but every change still needs to follow the requirements in the PR template. Two big areas that we have to watch for:
|
ninjarobot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good from the standpoint of functionality and compatibility. All the documentation is definitely appreciated as well.
|
This was rather question (with code attached) of do we want to take this direction, rather than a PR intended to be merged. We can close the PR but what you think about the idea? |
|
Reopened: Actually, as documentation improvement, this might be valuable. |
|
I'm good with the direction and I've been going through issues to see which ones are defined clearly enough to give to AI. It would definitely really help to tell it to focus on a feature at a time, though. Maintaining quality when there are huge change sets coming in from AI is really difficult. Breaking changes are incredibly detrimental to OSS projects - the last thing we want is for users to be concerned about taking upgrades. |
|
I had to do this for Copilot so it would fix up code to prevent fantomas failures. Is there something that could be added to the repo to make it easier for Claude as well? |
|
Generally working with all agents, you add AGENTS.md as general instructions and patterns how they should do things. You can ask e.g. Claude to generate you a template and then modify it by your needs. |
I did ask from Claude Sonnet what is in FsCDK (AWS) that Farmer (Azure) is missing, and it came up with this PR:
Farmer already has some opinionated approaches, but it doesn't really go into "production-environment-focus" (cost-efficiency, logging, hardened security, and so on).
Be suspicious about agents... Meanwhile this PR can be ready for merge, I'm not actually expecting that.
Rather the question is, would we want to take Farmer into this direction or no?