feat(clubList): search #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for computerization-enspire-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
at-wr
changed the title
This reverts commit 7f32f1b.
|
Done. Added icon to the tab list and hided text on small screens so the tab list would be much shorter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a brand new feature which allows user to search clubs in
/cas/clubvia its English or Chinese name while ignoring its capitalization. While there'ssearchTermin the search box, Tabs will be disabled.Such actions will be processed within user's browser without contacting the server.
Other project: #485
Known Issue
*and\may trigger 500 error page becuz of the usage ofregex