Skip to content

Remove middleware from NewProcessor() #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hariso merged 2 commits into from
Apr 10, 2025
Merged

Remove middleware from NewProcessor() #22

hariso merged 2 commits into from
Apr 10, 2025

Conversation

@hariso
Copy link
Contributor

@hariso hariso commented Apr 9, 2025 •
edited
Loading

Description

Fixes ConduitIO/conduit-processor-sdk#111.

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso mentioned this pull request Apr 9, 2025
Closed
maha-mstfa
maha-mstfa approved these changes Apr 9, 2025
View reviewed changes
Copy link

@maha-mstfa maha-mstfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@hariso hariso merged commit 89152b9 into main Apr 10, 2025
3 checks passed
@hariso hariso deleted the haris/remove-middleware branch April 10, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maha-mstfa maha-mstfa maha-mstfa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: using the default processor middleware in the processor template causes an error

3 participants

@hariso @maha-mstfa