This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: set the earliest block tag on startup when forking#3755
Merged
MicaiahReid merged 9 commits intoConsenSys-archive:developfrom Jan 12, 2023
Merged
fix: set the earliest block tag on startup when forking#3755MicaiahReid merged 9 commits intoConsenSys-archive:developfrom
earliest block tag on startup when forking#3755MicaiahReid merged 9 commits intoConsenSys-archive:developfrom
Conversation
MicaiahReid
suggested changes
Oct 5, 2022
Contributor
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
Great stuff, thanks for the PR! Just a tiny change and a question from me. Would love to see what @davidmurdoch thinks.
MicaiahReid
suggested changes
Oct 5, 2022
Contributor
Author
To be honest the important stuff is in: PR3692, this PRs are just to simplify 3692 |
MicaiahReid
suggested changes
Oct 6, 2022
davidmurdoch
suggested changes
Oct 6, 2022
Contributor
davidmurdoch
left a comment
davidmurdoch
left a comment
There was a problem hiding this comment.
Crazy that this bug has been in here for so long! Thanks so much for this PR!
I've requested a couple of changes, as well as pinged others for their opinions. If you don't want to make the changes yourself let me know and we can take over. Thanks again!
adjisb
requested review from
MicaiahReid and
davidmurdoch
and removed request for
MicaiahReid and
davidmurdoch
MicaiahReid
force-pushed
the
fix/forking_earliest
branch
from
bd337ad to
2baa643
Compare
MicaiahReid
suggested changes
Jan 5, 2023
MicaiahReid
force-pushed
the
fix/forking_earliest
branch
from
284ae4a to
a81bb40
Compare
MicaiahReid
requested review from
MicaiahReid,
davidmurdoch,
jeffsmale90 and
tenthirtyone
MicaiahReid
force-pushed
the
fix/forking_earliest
branch
from
a81bb40 to
446080a
Compare
davidmurdoch
approved these changes
Jan 6, 2023
MicaiahReid
approved these changes
Jan 6, 2023
MicaiahReid
changed the title
earliest block tag on startup when forking
jeffsmale90
approved these changes
Jan 11, 2023
MicaiahReid
force-pushed
the
fix/forking_earliest
branch
from
446080a to
d667dd5
Compare
Co-authored-by: Micaiah Reid <[email protected]>
Co-authored-by: Micaiah Reid <[email protected]>
Co-authored-by: David Murdoch <[email protected]>
MicaiahReid
force-pushed
the
fix/forking_earliest
branch
from
d667dd5 to
232c342
Compare
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Ganache Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates Ganache's startup procedure when forking to retrieve the
earliestblock from the remote and cache this block as theearliestblock in Ganache's block manager. This fixes a bug where callingeth_getBlockByNumberwith the"earliest"block tag parameter yielded no result.