Use Windmill Hub resource types, and document custom resource type usage #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudokemper
changed the title
|
Withdrawing this for now, as all 5/5 custom resources types were accepted to the Windmill Hub! Will revise to also close #132. |
rudokemper
changed the title
IamJeffG
approved these changes
Aug 14, 2025
rudokemper
added a commit
that referenced
this pull request
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Closes #132 and #130.
Now that all of our resource types were approved in Windmill Hub, this PR switches all of the relevant scripts and their definitions to use the Windmill Hub resource types instead of the
c_resource types. And also deletes the latter from this repo, since they are not needed any longer.Lastly, in regards to documenting how to add custom resource types to an instance, I thought to keep a few notes about this in case we do have to add a custom resource type in the future.