🎨 Palette: Make disabled hint button accessible - #1199
seonghobae wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head single-writer finding (0f9580cadf8d4569ce9d990dbc37b44ff84d58ad): 이 PR은 보호된 main@8dc7469…에서 ExportModal의 동일한 접근 관리 / native disabled → aria-disabled seam을 다시 쓰고 있습니다. 그런데 open inventory에 이미 #1061 (09f7bc62…)이 이 세 파일을 exact authority로 명시하고, 같은 product intent + focusability + description relation + activation cancellation regression을 소유하면서 #1085까지 verified-successor 방식으로 흡수한 canonical lane이 있습니다. #1073/#1090도 같은 계약의 browser/AT acceptance를 추적하고 있고, #1009는 그 위에 Storybook/Figma 상태 계약을 쌓고 있습니다. #1199를 독립 production writer로 유지하면 single-writer가 다시 깨집니다.
#1199 자체 evidence도 #1061보다 약합니다. 테스트는 aria-disabled/aria-describedby attribute만 확인하고 실제 normal Tab 순서, Enter/Space/pointer inertness, accessibility tree의 disabled+description, modal close/focus-return을 고정하지 않습니다. 따라서 단순 merge도, 단순 duplicate Close도 하지 말고 protected base/#1061/#1199를 exact differential로 비교해서 #1199의 유효 semantic delta가 #1061에 이미 완전 승계됐는지 먼저 증명해 주세요. unique delta가 있다면 #1061의 ordinary/non-force descendant 또는 명시적 canonical successor로 옮기고, source/test/CHANGELOG/Storybook·Figma evidence까지 한 owner lane에 모으는 것이 맞습니다.
GREEN acceptance는 동일 exact head에서 (1) Tab으로 실제 이 버튼에 도달, (2) Enter/Space/pointer가 action/state mutation을 만들지 않음, (3) computed accessibility tree가 disabled와 share-export-access-hint 설명을 노출, (4) desktop/intermediate/mobile에서 focus-visible/disabled styling이 유지, (5) normal/loading/permission/close-focus-return 상태 회귀 없음, (6) Chromium/Firefox/WebKit browser evidence입니다. 현재 판정은 product direction VALID / single-writer FAIL / complete succession PENDING / UI Delivery Gate FAIL입니다.
💡 What: Changed the disabled attribute on the "접근 관리" button to aria-disabled="true" with a manual event interrupter. 🎯 Why: To ensure screen readers can focus the button and read its aria-describedby hint. 📸 Before/After: Visuals remain unchanged. ♿ Accessibility: Fixes an issue where native disabled attributes remove elements from tab order, hiding crucial explanatory text from assistive technologies.
PR created automatically by Jules for task 7580826185520812553 started by @seonghobae