Fix: Reuse PairedTransmitter outside loop to prevent repeated ZMQ socket creation (#268)#294
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the resource lifecycle in the 0mq/funcall.py ZMQ client loop by reusing a single PairedTransmitter instance instead of creating/tearing it down every iteration, avoiding repeated socket/thread churn.
Changes:
- Instantiate
PairedTransmitteronce before the simulation loop. - Start background sync once and stop it once using a
try/finallyto guarantee cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey pradeeban,
Fixes #268.
In
0mq/funcall.py,PairedTransmitterwas being created and destroyed inside every loop iteration. This resulted in unnecessary ZMQ socket creation, extra thread overhead, and in some cases port rebinding problems due to the TIME_WAIT state.To fix this, the transmitter initialization and background thread start are moved outside the loop so they are created only once. A
try/finallyblock is also added to ensure the transmitter is properly cleaned up after the loop finishes.This improves performance and avoids potential socket exhaustion while keeping the existing behavior unchanged.