Fix concore validate exit code and add missing source file checks#304
Merged
pradeeban merged 2 commits intoControlCore-Project:devfrom Feb 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pradeeban , This PR fixes issue #303
Summary
concore validatenow exits non‑zero when errors are found.src/).--sourceoption for validate.Problem
concore validateprints errors but still exits with code 0, which makes it ineffective in CI/pre‑commit usage. The README also states file references are validated, but validate didn’t actually check whether node source files exist.Solution
validate_workflownow returns success/failure and the CLI exits with code 1 on errors.--sourcetoconcore validateto align withrunandinspect.Tests
Checklist
python -m pytest -v tests/test_cli.py)Note to Maintainers
Thanks for reviewing! I aimed to align
concore validatewith the documented behavior and make it reliable for CI by returning a proper exit code and checking missing node source files. If you want the validation scope or error/warning thresholds adjusted, I’m happy to iterate quickly.