Remove outdated concore copies from testsou to prevent divergence (#289)#305
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 14, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes multiple stale, duplicated concore.py / concore2.py implementations under testsou/ to reduce divergence from the main concore.py and eliminate local shadowing/confusion risks.
Changes:
- Deleted 9 outdated local copies of
concore.py/concore2.pyfromtestsou/and its subfolders. - Removed legacy variants (
concoreold.py,concoredocker.py) fromtestsou/to enforce a single source of truth.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testsou/concore.py | Removes testsou-local concore implementation to avoid drift/shadowing. |
| testsou/concoreold.py | Removes legacy concore variant from testsou. |
| testsou/concoredocker.py | Removes testsou-local docker-specific concore variant. |
| testsou/ccpymat.dir/concore.py | Removes per-example concore copy under ccpymat. |
| testsou/pmcpymat.dir/concore.py | Removes per-example concore copy under pmcpymat. |
| testsou/funbody.dir/concore2.py | Removes per-example concore2 copy under funbody. |
| testsou/funcall.dir/concore2.py | Removes per-example concore2 copy under funcall. |
| testsou/mix.dir/concore2.py | Removes per-example concore2 copy under mix. |
| testsou/powermetermax.dir/concore2.py | Removes per-example concore2 copy under powermetermax. |
Comments suppressed due to low confidence (4)
testsou/ccpymat.dir/concore.py:1
testsou/ccpymat.dir/cpymat.pydoesimport concore. With this file removed, running that script from insidetestsou/ccpymat.dirwill raiseModuleNotFoundErrorunless the repo root is added toPYTHONPATH/sys.path. If these*.dirfolders are intended to be runnable entrypoints, consider updating the runner/scripts to include the repo root onsys.path(or convertingconcore.pyinto an installable module).
testsou/pmcpymat.dir/concore.py:1testsou/pmcpymat.dir/pmpymat.pydoesimport concore. With this local module removed, running from withintestsou/pmcpymat.dirwill no longer resolveconcoreunless the repo root is onPYTHONPATH/sys.path. If these example directories are still supported, consider adding a small path bootstrap in the scripts or documenting the required invocation (e.g., run from repo root with an explicitPYTHONPATH).
testsou/concore.py:1- Removing this local
testsou/concore.pycopy means running scripts fromtestsou/viapython testsou/<script>.py(or from insidetestsou/) will no longer be able to resolveimport concore, because the repo root isn’t onsys.pathin that execution mode andsetup.pydoesn’t packageconcore.pyfor installation. If these scripts are still expected to be runnable, consider updating them to add the repo root tosys.path(or packagingconcore.pyas an installable module) and adjust the PR description (“No behavior changes”) accordingly.
testsou/funcall.dir/concore2.py:1 - After deleting the
concore2.pycopies undertestsou/*/*.dir/, there is no longer anyconcore2module available when running thetestsou/*.pyexamples that doimport concore2(e.g.testsou/funcall.py,testsou/mix.py,testsou/powermetermax.py). If those examples are meant to remain usable, consider adding a single supportedconcore2shim (e.g., loadingconcore.pyunder a second module name to keep separate globals) or updating the examples to avoid relying onconcore2imports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pradeeban
Problem:
The testsou/ directory contained 9 outdated local copies of concore.py / concore2.py that diverged from the main implementation. These stale duplicates lacked default_maxtime(), tryparam()/params, ZMQ support, proper sys.exit() handling, and other core features — creating import shadowing risk, contributor confusion, and test instability.
Solution:
Removed all 9 stale duplicate concore implementations from testsou/:
concore.py
concoreold.py
concoredocker.py
concore.py
concore.py
concore2.py
concore2.py
Impact:
No functional changes
No API changes
No behavior changes
Root concore.py untouched
All 57 tests pass
Enforces single source of truth
Eliminates import shadowing risk
Closes #289
